From: Johan Hovold <johan@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: "Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>,
"Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@oss.qualcomm.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI: qcom: Move qcom_pcie_icc_opp_update() to notifier callback
Date: Mon, 21 Jul 2025 11:02:01 +0200 [thread overview]
Message-ID: <aH4CCUY8RRtUywmE@hovoldconsulting.com> (raw)
In-Reply-To: <qg4dof65dyggzgvkroeo2suhhnvosqs3dnkrmsqpbf4z67dcht@ltzirahk2mxd>
On Wed, Jul 16, 2025 at 12:16:42PM +0530, Manivannan Sadhasivam wrote:
> On Wed, Jul 16, 2025 at 10:24:23AM GMT, Krishna Chaitanya Chundru wrote:
> > How about using enable_device in host bridge, without pci_enable_device
> > call the endpoints can't start the transfers. May be we can use that.
>
> Q: Who is going to call pci_enable_device()?
> A: The PCI client driver
>
> This is same as relying on BUS_NOTIFY_BIND_DRIVER notifier.
It seems to me that enable_device() may be a better fit if we're only
going to enable ASPM for devices with a driver (or when enabled through
sysfs).
PCI core will already have placed the device in D0, and this avoids
dealing with notifiers.
Johan
next prev parent reply other threads:[~2025-07-21 9:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 18:01 [PATCH 0/2] PCI: qcom: Switch to bus notifier for enabling ASPM of PCI devices Manivannan Sadhasivam
2025-07-14 18:01 ` [PATCH 1/2] " Manivannan Sadhasivam
2025-07-15 7:48 ` Johan Hovold
2025-07-15 9:11 ` Manivannan Sadhasivam
2025-07-15 9:33 ` Johan Hovold
2025-07-15 9:46 ` Konrad Dybcio
2025-07-15 10:27 ` Manivannan Sadhasivam
2025-07-15 12:31 ` Johan Hovold
2025-07-21 9:32 ` Johan Hovold
2025-07-21 10:56 ` Manivannan Sadhasivam
2025-07-21 12:49 ` Johan Hovold
2025-07-21 15:45 ` Manivannan Sadhasivam
2025-07-14 18:01 ` [PATCH 2/2] PCI: qcom: Move qcom_pcie_icc_opp_update() to notifier callback Manivannan Sadhasivam
2025-07-15 7:51 ` Johan Hovold
2025-07-15 9:13 ` Manivannan Sadhasivam
2025-07-15 9:54 ` Konrad Dybcio
2025-07-15 10:36 ` Manivannan Sadhasivam
2025-07-15 10:45 ` Konrad Dybcio
2025-07-16 5:28 ` Manivannan Sadhasivam
2025-07-16 10:33 ` Konrad Dybcio
2025-07-21 9:15 ` Johan Hovold
2025-07-16 4:54 ` Krishna Chaitanya Chundru
2025-07-16 6:46 ` Manivannan Sadhasivam
2025-07-16 6:53 ` Krishna Chaitanya Chundru
2025-07-16 7:18 ` Manivannan Sadhasivam
2025-07-21 9:02 ` Johan Hovold [this message]
2025-07-21 10:59 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aH4CCUY8RRtUywmE@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=bhelgaas@google.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®