* [PATCH v2] drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST [not found] <20250701115511.5445-1-rubenru09.ref@aol.com> @ 2025-07-01 11:54 ` Ruben Wauters 2025-07-18 13:59 ` Ruben Wauters 0 siblings, 1 reply; 4+ messages in thread From: Ruben Wauters @ 2025-07-01 11:54 UTC (permalink / raw) To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, David Airlie, Simona Vetter Cc: Ruben Wauters, intel-gfx, dri-devel, linux-kernel, kernel-janitors DRM_DEBUG_SELFTEST was removed in commit fc8d29e298cf (drm: selftest: convert drm_mm selftest to KUnit) and all functions under it were converted to KUnit, under the DRM_KUNIT_TEST option This conversion however did not occur in the Kconfig.debug file in the i915 directory. This patch replaces the select for DRM_DEBUG_SELFTEST, an option that no longer exists, with the correct select, DRM_KUNIT_TEST. Signed-off-by: Ruben Wauters <rubenru09@aol.com> --- v2 changes: - update commit message to contain more detail about the background of the change and why it is necessary --- drivers/gpu/drm/i915/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug index 1852e0804942..b15b1cecb3aa 100644 --- a/drivers/gpu/drm/i915/Kconfig.debug +++ b/drivers/gpu/drm/i915/Kconfig.debug @@ -50,7 +50,7 @@ config DRM_I915_DEBUG select DRM_VGEM # used by igt/prime_vgem (dmabuf interop checks) select DRM_DEBUG_MM if DRM=y select DRM_EXPORT_FOR_TESTS if m - select DRM_DEBUG_SELFTEST + select DRM_KUNIT_TEST select DMABUF_SELFTESTS select SW_SYNC # signaling validation framework (igt/syncobj*) select DRM_I915_WERROR -- 2.48.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST 2025-07-01 11:54 ` [PATCH v2] drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST Ruben Wauters @ 2025-07-18 13:59 ` Ruben Wauters 2025-07-18 16:19 ` Rodrigo Vivi 0 siblings, 1 reply; 4+ messages in thread From: Ruben Wauters @ 2025-07-18 13:59 UTC (permalink / raw) To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, David Airlie, Simona Vetter Cc: intel-gfx, dri-devel, linux-kernel, kernel-janitors On Tue, 2025-07-01 at 12:54 +0100, Ruben Wauters wrote: > DRM_DEBUG_SELFTEST was removed in commit fc8d29e298cf (drm: selftest: > convert drm_mm selftest to KUnit) and all functions under it were > converted to KUnit, under the DRM_KUNIT_TEST option > > This conversion however did not occur in the Kconfig.debug file in > the > i915 directory. > > This patch replaces the select for DRM_DEBUG_SELFTEST, an option that > no > longer exists, with the correct select, DRM_KUNIT_TEST. > > Signed-off-by: Ruben Wauters <rubenru09@aol.com> > --- > v2 changes: > - update commit message to contain more detail about the background > of > the change and why it is necessary > --- > drivers/gpu/drm/i915/Kconfig.debug | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/Kconfig.debug > b/drivers/gpu/drm/i915/Kconfig.debug > index 1852e0804942..b15b1cecb3aa 100644 > --- a/drivers/gpu/drm/i915/Kconfig.debug > +++ b/drivers/gpu/drm/i915/Kconfig.debug > @@ -50,7 +50,7 @@ config DRM_I915_DEBUG > select DRM_VGEM # used by igt/prime_vgem (dmabuf interop > checks) > select DRM_DEBUG_MM if DRM=y > select DRM_EXPORT_FOR_TESTS if m > - select DRM_DEBUG_SELFTEST > + select DRM_KUNIT_TEST > select DMABUF_SELFTESTS > select SW_SYNC # signaling validation framework > (igt/syncobj*) > select DRM_I915_WERROR Hello, I was wondering if it'd be possible to have this patch reviewed. Having an incorrect Kconfig entry isn't ideal and it'd be good if this could be fixed if possible Thanks Ruben Wauters ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST 2025-07-18 13:59 ` Ruben Wauters @ 2025-07-18 16:19 ` Rodrigo Vivi 2025-07-21 14:47 ` Rodrigo Vivi 0 siblings, 1 reply; 4+ messages in thread From: Rodrigo Vivi @ 2025-07-18 16:19 UTC (permalink / raw) To: Ruben Wauters Cc: Jani Nikula, Joonas Lahtinen, Tvrtko Ursulin, David Airlie, Simona Vetter, intel-gfx, dri-devel, linux-kernel, kernel-janitors On Fri, Jul 18, 2025 at 02:59:10PM +0100, Ruben Wauters wrote: > On Tue, 2025-07-01 at 12:54 +0100, Ruben Wauters wrote: > > DRM_DEBUG_SELFTEST was removed in commit fc8d29e298cf (drm: selftest: > > convert drm_mm selftest to KUnit) and all functions under it were > > converted to KUnit, under the DRM_KUNIT_TEST option > > > > This conversion however did not occur in the Kconfig.debug file in > > the > > i915 directory. I wonder if some deeper conversion is needed on the selftests. But well, I couldn't spot anything and if CI is happy, let's go with ti. > > > > This patch replaces the select for DRM_DEBUG_SELFTEST, an option that > > no > > longer exists, with the correct select, DRM_KUNIT_TEST. > > > > Signed-off-by: Ruben Wauters <rubenru09@aol.com> > > --- > > v2 changes: > > - update commit message to contain more detail about the background > > of > > the change and why it is necessary > > --- > > drivers/gpu/drm/i915/Kconfig.debug | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/Kconfig.debug > > b/drivers/gpu/drm/i915/Kconfig.debug > > index 1852e0804942..b15b1cecb3aa 100644 > > --- a/drivers/gpu/drm/i915/Kconfig.debug > > +++ b/drivers/gpu/drm/i915/Kconfig.debug > > @@ -50,7 +50,7 @@ config DRM_I915_DEBUG > > select DRM_VGEM # used by igt/prime_vgem (dmabuf interop > > checks) > > select DRM_DEBUG_MM if DRM=y > > select DRM_EXPORT_FOR_TESTS if m > > - select DRM_DEBUG_SELFTEST > > + select DRM_KUNIT_TEST > > select DMABUF_SELFTESTS > > select SW_SYNC # signaling validation framework > > (igt/syncobj*) > > select DRM_I915_WERROR > > Hello, I was wondering if it'd be possible to have this patch reviewed. > Having an incorrect Kconfig entry isn't ideal and it'd be good if this > could be fixed if possible I just resent for CI before we can merge. Thanks for the patch... > > Thanks > > Ruben Wauters ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST 2025-07-18 16:19 ` Rodrigo Vivi @ 2025-07-21 14:47 ` Rodrigo Vivi 0 siblings, 0 replies; 4+ messages in thread From: Rodrigo Vivi @ 2025-07-21 14:47 UTC (permalink / raw) To: Ruben Wauters Cc: Jani Nikula, Joonas Lahtinen, Tvrtko Ursulin, David Airlie, Simona Vetter, intel-gfx, dri-devel, linux-kernel, kernel-janitors On Fri, Jul 18, 2025 at 12:19:41PM -0400, Rodrigo Vivi wrote: > On Fri, Jul 18, 2025 at 02:59:10PM +0100, Ruben Wauters wrote: > > On Tue, 2025-07-01 at 12:54 +0100, Ruben Wauters wrote: > > > DRM_DEBUG_SELFTEST was removed in commit fc8d29e298cf (drm: selftest: > > > convert drm_mm selftest to KUnit) and all functions under it were > > > converted to KUnit, under the DRM_KUNIT_TEST option > > > > > > This conversion however did not occur in the Kconfig.debug file in > > > the > > > i915 directory. > > I wonder if some deeper conversion is needed on the selftests. > But well, I couldn't spot anything and if CI is happy, let's go with ti. > > > > > > > This patch replaces the select for DRM_DEBUG_SELFTEST, an option that > > > no > > > longer exists, with the correct select, DRM_KUNIT_TEST. > > > > > > Signed-off-by: Ruben Wauters <rubenru09@aol.com> > > > --- > > > v2 changes: > > > - update commit message to contain more detail about the background > > > of > > > the change and why it is necessary > > > --- > > > drivers/gpu/drm/i915/Kconfig.debug | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/Kconfig.debug > > > b/drivers/gpu/drm/i915/Kconfig.debug > > > index 1852e0804942..b15b1cecb3aa 100644 > > > --- a/drivers/gpu/drm/i915/Kconfig.debug > > > +++ b/drivers/gpu/drm/i915/Kconfig.debug > > > @@ -50,7 +50,7 @@ config DRM_I915_DEBUG > > > select DRM_VGEM # used by igt/prime_vgem (dmabuf interop > > > checks) > > > select DRM_DEBUG_MM if DRM=y > > > select DRM_EXPORT_FOR_TESTS if m > > > - select DRM_DEBUG_SELFTEST > > > + select DRM_KUNIT_TEST > > > select DMABUF_SELFTESTS > > > select SW_SYNC # signaling validation framework > > > (igt/syncobj*) > > > select DRM_I915_WERROR > > > > Hello, I was wondering if it'd be possible to have this patch reviewed. > > Having an incorrect Kconfig entry isn't ideal and it'd be good if this > > could be fixed if possible > > I just resent for CI before we can merge. pushed to drm-intel-next Thanks for the patch. > > Thanks for the patch... > > > > > Thanks > > > > Ruben Wauters ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-21 14:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20250701115511.5445-1-rubenru09.ref@aol.com>
2025-07-01 11:54 ` [PATCH v2] drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST Ruben Wauters
2025-07-18 13:59 ` Ruben Wauters
2025-07-18 16:19 ` Rodrigo Vivi
2025-07-21 14:47 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®