Re: [PATCH v3 1/5] panic: clean up code for console replay

[Feng Tang <feng.tang@linux.alibaba.com>]

On Tue, Jul 15, 2025 at 05:18:10AM +0400, Askar Safin wrote:
>  ---- On Tue, 15 Jul 2025 04:49:12 +0400  Feng Tang <feng.tang@linux.alibaba.com> wrote --- 
>  > Thanks for trying the patch! 
> I didn't try it. :) I merely run normal mainline or distro kernel in qemu.
> 
>  > My understanding is, 'console' have kind of different meaning in kernel
>  > space than just /dev/console. In printk.c, you can see 'console' is
>  > used everywhere,  which are mostly bound to kernel message.like
>  > console_try_replay_all(), console_flush_all(), console_flush_on_panic(),
>  > which are consistent with the new name suggested by Petr.
> Okay, I agree.
> 
> But I still kindly ask you to revert changes to Documentation/admin-guide/kernel-parameters.txt .
> Previous documentation is better.
> admin-guide is written for admins, not for kernel developers. And they understand "console" as /dev/console .
> 
> I run kernel with panic_print=32 in hope that this will flush console (i. e. /dev/console), because this is how I interpreted
> your patched documentation. And I got different effect.

I see. How about changing the patch to: 

-			bit 5: print all printk messages in buffer
+			bit 5: replay all kernel messages on consoles at the end of panic

Thanks,
Feng

> 
> --
> Askar Safin
> https://types.pl/@safinaskar