mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Feng Tang <feng.tang@linux.alibaba.com>
Cc: Askar Safin <safinaskar@zohomail.com>,
	akpm <akpm@linux-foundation.org>, corbet <corbet@lwn.net>,
	"john.ogness" <john.ogness@linutronix.de>,
	"lance.yang" <lance.yang@linux.dev>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	paulmck <paulmck@kernel.org>, rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v3 1/5] panic: clean up code for console replay
Date: Tue, 12 Aug 2025 13:59:32 +0200	[thread overview]
Message-ID: <aJsspG0JdxyRLNte@pathway> (raw)
In-Reply-To: <aHXKuiqELS1tmchE@U-2FWC9VHC-2323.local>

On Tue 2025-07-15 11:27:54, Feng Tang wrote:
> On Tue, Jul 15, 2025 at 06:48:47AM +0400, Askar Safin wrote:
> > 
> >  ---- On Tue, 15 Jul 2025 05:34:39 +0400  Feng Tang <feng.tang@linux.alibaba.com> wrote --- 
> >  > I see. How about changing the patch to: 
> >  > 
> >  > -            bit 5: print all printk messages in buffer
> >  > +            bit 5: replay all kernel messages on consoles at the end of panic
> > 
> > Yes, I agree!
> 
> Hi Andrew,
> 
> Could you help to squash below patch to 1/5 patch "panic: clean up code
> for console replay" in the nonmmu-unstable branch? Thanks!
> 
> - Feng
> 
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index f34de9978a91..a84d3f7f5bbf 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -4533,7 +4533,7 @@
>  			bit 2: print timer info
>  			bit 3: print locks info if CONFIG_LOCKDEP is on
>  			bit 4: print ftrace buffer
> -			bit 5: replay all messages on consoles at the end of panic
> +			bit 5: replay all kernel messages on consoles at the end of panic
>  			bit 6: print all CPUs backtrace (if available in the arch)
>  			bit 7: print only tasks in uninterruptible (blocked) state
>  			*Be aware* that this option may print a _lot_ of lines,

Yes, this looks better.

It sees that this change is missing in the mainline.
Fang, could you please send it as a followup fix, please?

Best Regards,
Petr

  reply	other threads:[~2025-08-12 11:59 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-03  2:09 [PATCH v3 0/5] generalize panic_print's dump function to be used by other kernel parts Feng Tang
2025-07-03  2:10 ` [PATCH v3 1/5] panic: clean up code for console replay Feng Tang
2025-07-14 21:09   ` Askar Safin
2025-07-15  0:49     ` Feng Tang
2025-07-15  1:18       ` Askar Safin
2025-07-15  1:34         ` Feng Tang
2025-07-15  2:48           ` Askar Safin
2025-07-15  3:27             ` Feng Tang
2025-08-12 11:59               ` Petr Mladek [this message]
2025-08-13  0:43                 ` Feng Tang
2025-07-03  2:10 ` [PATCH v3 2/5] panic: generalize panic_print's function to show sys info Feng Tang
2025-08-12 10:12   ` Petr Mladek
2025-07-03  2:10 ` [PATCH 3/5] panic: add 'panic_sys_info' sysctl to take human readable string parameter Feng Tang
2025-07-03  2:56   ` Lance Yang
2025-07-03  3:18     ` Feng Tang
2025-08-12 10:23   ` Petr Mladek
2025-08-13  0:39     ` Feng Tang
2025-07-03  2:10 ` [PATCH v3 4/5] panic: add 'panic_sys_info=' setup option for kernel cmdline Feng Tang
2025-08-12 10:31   ` Petr Mladek
2025-07-03  2:10 ` [PATCH v3 5/5] panic: add note that panic_print sysctl interface is deprecated Feng Tang
2025-08-12 11:52   ` Petr Mladek
2025-08-13  1:05     ` Feng Tang
2025-08-14 15:21       ` Petr Mladek
2025-07-03  3:23 ` [PATCH v3 0/5] generalize panic_print's dump function to be used by other kernel parts Lance Yang
2025-07-03  4:56   ` Lance Yang
2025-07-03  5:54     ` Feng Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJsspG0JdxyRLNte@pathway \
    --to=pmladek@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=feng.tang@linux.alibaba.com \
    --cc=john.ogness@linutronix.de \
    --cc=lance.yang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=safinaskar@zohomail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®