* Re: [PATCH] clocksource/timer-econet-en751221: Convert comma to semicolon
2025-06-03 6:04 [PATCH] clocksource/timer-econet-en751221: Convert comma to semicolon Chen Ni
@ 2025-06-03 10:05 ` Caleb James DeLisle
2025-07-15 11:24 ` Daniel Lezcano
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Caleb James DeLisle @ 2025-06-03 10:05 UTC (permalink / raw)
To: Chen Ni, daniel.lezcano, tglx; +Cc: linux-mips, linux-kernel
On 03/06/2025 08:04, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Tested-by: Caleb James DeLisle <cjd@cjdns.fr>
The comma was indeed unintended, thank you.
Caleb
> ---
> drivers/clocksource/timer-econet-en751221.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-econet-en751221.c b/drivers/clocksource/timer-econet-en751221.c
> index 3b449fdaafee..4008076b1a21 100644
> --- a/drivers/clocksource/timer-econet-en751221.c
> +++ b/drivers/clocksource/timer-econet-en751221.c
> @@ -146,7 +146,7 @@ static int __init cevt_init(struct device_node *np)
> for_each_possible_cpu(i) {
> struct clock_event_device *cd = &per_cpu(econet_timer_pcpu, i);
>
> - cd->rating = 310,
> + cd->rating = 310;
> cd->features = CLOCK_EVT_FEAT_ONESHOT |
> CLOCK_EVT_FEAT_C3STOP |
> CLOCK_EVT_FEAT_PERCPU;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] clocksource/timer-econet-en751221: Convert comma to semicolon
2025-06-03 6:04 [PATCH] clocksource/timer-econet-en751221: Convert comma to semicolon Chen Ni
2025-06-03 10:05 ` Caleb James DeLisle
@ 2025-07-15 11:24 ` Daniel Lezcano
2025-07-23 7:17 ` [tip: timers/clocksource] " tip-bot2 for Chen Ni
2025-07-25 10:31 ` tip-bot2 for Chen Ni
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Lezcano @ 2025-07-15 11:24 UTC (permalink / raw)
To: Chen Ni; +Cc: cjd, tglx, linux-mips, linux-kernel
On Tue, Jun 03, 2025 at 02:04:50PM +0800, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip: timers/clocksource] clocksource/timer-econet-en751221: Convert comma to semicolon
2025-06-03 6:04 [PATCH] clocksource/timer-econet-en751221: Convert comma to semicolon Chen Ni
2025-06-03 10:05 ` Caleb James DeLisle
2025-07-15 11:24 ` Daniel Lezcano
@ 2025-07-23 7:17 ` tip-bot2 for Chen Ni
2025-07-25 10:31 ` tip-bot2 for Chen Ni
3 siblings, 0 replies; 5+ messages in thread
From: tip-bot2 for Chen Ni @ 2025-07-23 7:17 UTC (permalink / raw)
To: linux-tip-commits
Cc: Chen Ni, Caleb James DeLisle, Daniel Lezcano, x86, linux-kernel
The following commit has been merged into the timers/clocksource branch of tip:
Commit-ID: 85242ccffd57ba4f8dceec7e520da6065d20fd87
Gitweb: https://git.kernel.org/tip/85242ccffd57ba4f8dceec7e520da6065d20fd87
Author: Chen Ni <nichen@iscas.ac.cn>
AuthorDate: Tue, 03 Jun 2025 14:04:50 +08:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Tue, 15 Jul 2025 13:23:38 +02:00
clocksource/timer-econet-en751221: Convert comma to semicolon
Replace comma between expressions with semicolons.
Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.
Found by inspection.
No functional change intended.
Compile tested only.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Tested-by: Caleb James DeLisle <cjd@cjdns.fr>
Link: https://lore.kernel.org/r/20250603060450.1310204-1-nichen@iscas.ac.cn
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/clocksource/timer-econet-en751221.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-econet-en751221.c b/drivers/clocksource/timer-econet-en751221.c
index 3b449fd..4008076 100644
--- a/drivers/clocksource/timer-econet-en751221.c
+++ b/drivers/clocksource/timer-econet-en751221.c
@@ -146,7 +146,7 @@ static int __init cevt_init(struct device_node *np)
for_each_possible_cpu(i) {
struct clock_event_device *cd = &per_cpu(econet_timer_pcpu, i);
- cd->rating = 310,
+ cd->rating = 310;
cd->features = CLOCK_EVT_FEAT_ONESHOT |
CLOCK_EVT_FEAT_C3STOP |
CLOCK_EVT_FEAT_PERCPU;
^ permalink raw reply [flat|nested] 5+ messages in thread* [tip: timers/clocksource] clocksource/timer-econet-en751221: Convert comma to semicolon
2025-06-03 6:04 [PATCH] clocksource/timer-econet-en751221: Convert comma to semicolon Chen Ni
` (2 preceding siblings ...)
2025-07-23 7:17 ` [tip: timers/clocksource] " tip-bot2 for Chen Ni
@ 2025-07-25 10:31 ` tip-bot2 for Chen Ni
3 siblings, 0 replies; 5+ messages in thread
From: tip-bot2 for Chen Ni @ 2025-07-25 10:31 UTC (permalink / raw)
To: linux-tip-commits
Cc: Chen Ni, Daniel Lezcano, Ingo Molnar, Caleb James DeLisle, x86,
linux-kernel
The following commit has been merged into the timers/clocksource branch of tip:
Commit-ID: 7a3174ef0ce3b507a4a22b25822f13f454eab9f4
Gitweb: https://git.kernel.org/tip/7a3174ef0ce3b507a4a22b25822f13f454eab9f4
Author: Chen Ni <nichen@iscas.ac.cn>
AuthorDate: Tue, 03 Jun 2025 14:04:50 +08:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Fri, 25 Jul 2025 12:07:01 +02:00
clocksource/timer-econet-en751221: Convert comma to semicolon
Replace comma between expressions with semicolons.
Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.
Found by inspection.
No functional change intended.
Compile tested only.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Caleb James DeLisle <cjd@cjdns.fr>
Link: https://lore.kernel.org/r/20250603060450.1310204-1-nichen@iscas.ac.cn
---
drivers/clocksource/timer-econet-en751221.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-econet-en751221.c b/drivers/clocksource/timer-econet-en751221.c
index 3b449fd..4008076 100644
--- a/drivers/clocksource/timer-econet-en751221.c
+++ b/drivers/clocksource/timer-econet-en751221.c
@@ -146,7 +146,7 @@ static int __init cevt_init(struct device_node *np)
for_each_possible_cpu(i) {
struct clock_event_device *cd = &per_cpu(econet_timer_pcpu, i);
- cd->rating = 310,
+ cd->rating = 310;
cd->features = CLOCK_EVT_FEAT_ONESHOT |
CLOCK_EVT_FEAT_C3STOP |
CLOCK_EVT_FEAT_PERCPU;
^ permalink raw reply [flat|nested] 5+ messages in thread