From: Pavel Machek <pavel@ucw.cz>
To: E Shattow <e@freeshell.de>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Are LED functions strings or uint32 in Documentation/devicetree/bindings/leds/common.yaml
Date: Wed, 16 Jul 2025 07:13:55 +0200 [thread overview]
Message-ID: <aHc1E2xPMfvKYcYx@duo.ucw.cz> (raw)
In-Reply-To: <91d71a35-bb22-4482-8b49-398899ee37ae@freeshell.de>
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
Hi!
> Documentation/devicetree/bindings/leds/common.yaml [1] describes a
> uint32 but the $ref is for a string, for "function". What's going on
> there? Also what is the reasoning for that sort ordering [2] in the
> examples, are we saying that gpios is like a register and function or
> default-state is a kind of status?
>
> 1:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/leds/common.yaml
>
You may want to cc devicetree people and linux-leds mailing list.
Take a look at include/dt-bindings/leds/common.h, LED_FUNCTION_PANIC
(for example) is a string, so documentation looks consistent to me.
BR,
Pavel
--
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, and Musk!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2025-07-16 5:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 3:19 E Shattow
2025-07-16 5:13 ` Pavel Machek [this message]
2025-07-16 5:38 ` E Shattow
2025-07-16 10:17 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHc1E2xPMfvKYcYx@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=e@freeshell.de \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®