From: E Shattow <e@freeshell.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-leds@vger.kernel.org
Subject: Re: Are LED functions strings or uint32 in Documentation/devicetree/bindings/leds/common.yaml
Date: Tue, 15 Jul 2025 22:38:44 -0700 [thread overview]
Message-ID: <e6e4eb98-f535-4fa5-af3e-5d144275b05a@freeshell.de> (raw)
In-Reply-To: <aHc1E2xPMfvKYcYx@duo.ucw.cz>
On 7/15/25 22:13, Pavel Machek wrote:
> Hi!
>
>> Documentation/devicetree/bindings/leds/common.yaml [1] describes a
>> uint32 but the $ref is for a string, for "function". What's going on
>> there? Also what is the reasoning for that sort ordering [2] in the
>> examples, are we saying that gpios is like a register and function or
>> default-state is a kind of status?
>>
>> 1:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/leds/common.yaml
>>
>
> You may want to cc devicetree people and linux-leds mailing list.
>
> Take a look at include/dt-bindings/leds/common.h, LED_FUNCTION_PANIC
> (for example) is a string, so documentation looks consistent to me.
>
> BR,
> Pavel
Hi Pavel, thanks for the correction. That makes sense to me now, it is
more of a function name than a function enum.
Question about the dts examples' sort ordering remains? I try to follow
the devicetree code style document but I must get confused too easily :-)
Cheers,
-E
CC: devicetree, linux-leds
next prev parent reply other threads:[~2025-07-16 5:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 3:19 E Shattow
2025-07-16 5:13 ` Pavel Machek
2025-07-16 5:38 ` E Shattow [this message]
2025-07-16 10:17 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6e4eb98-f535-4fa5-af3e-5d144275b05a@freeshell.de \
--to=e@freeshell.de \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®