[PATCH -resend] misc: ti_fpc202: Switch to of_fwnode_handle()

[PATCH -resend] misc: ti_fpc202: Switch to of_fwnode_handle()

[Jiri Slaby (SUSE)]

of_node_to_fwnode() is an irqdomain's reimplementation of the
"officially" defined of_fwnode_handle(). The former is in the process of
being removed, so use the latter instead.

This is the last in-tree user.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Fixes: 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver")
Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/misc/ti_fpc202.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/ti_fpc202.c b/drivers/misc/ti_fpc202.c
index f84cae50e2c9..0b1a6350c02b 100644
--- a/drivers/misc/ti_fpc202.c
+++ b/drivers/misc/ti_fpc202.c
@@ -281,7 +281,7 @@ static int fpc202_probe_port(struct fpc202_priv *priv, struct device_node *i2c_h
 
 	desc.chan_id = port_id;
 	desc.parent = dev;
-	desc.bus_handle = of_node_to_fwnode(i2c_handle);
+	desc.bus_handle = of_fwnode_handle(i2c_handle);
 	desc.num_aliases = FPC202_ALIASES_PER_PORT;
 
 	fpc202_fill_alias_table(priv->client, aliases, port_id);
-- 
2.50.1

Re: [PATCH -resend] misc: ti_fpc202: Switch to of_fwnode_handle()

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

On Wed, Jul 23, 2025 at 07:35:16AM +0200, Jiri Slaby (SUSE) wrote:
> of_node_to_fwnode() is an irqdomain's reimplementation of the
> "officially" defined of_fwnode_handle(). The former is in the process of
> being removed, so use the latter instead.
> 
> This is the last in-tree user.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Fixes: 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver")
> Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH -resend] misc: ti_fpc202: Switch to of_fwnode_handle()

[Jiri Slaby]

On 23. 07. 25, 7:49, Wolfram Sang wrote:
> On Wed, Jul 23, 2025 at 07:35:16AM +0200, Jiri Slaby (SUSE) wrote:
>> of_node_to_fwnode() is an irqdomain's reimplementation of the
>> "officially" defined of_fwnode_handle(). The former is in the process of
>> being removed, so use the latter instead.
>>
>> This is the last in-tree user.
>>
>> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
>> Fixes: 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver")
>> Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Well, who is supposed to pick this up? I thought you.

But given you marked it as such -- Greg?

thanks,
-- 
js
suse labs

Re: [PATCH -resend] misc: ti_fpc202: Switch to of_fwnode_handle()

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]


> > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Well, who is supposed to pick this up? I thought you.
> 
> But given you marked it as such -- Greg?

Technically, yes, Greg. I took the driver together with the I2C ATR
feature because it was its first user. But other than that, it doesn't
belong to the I2C realm. That being said, I can pick this patch to help
removing the deprecated function if Greg doesn't pick it in the next
days.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH -resend] misc: ti_fpc202: Switch to of_fwnode_handle()

[Greg Kroah-Hartman]

On Wed, Jul 23, 2025 at 08:15:50AM +0200, Wolfram Sang wrote:
> 
> > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > 
> > Well, who is supposed to pick this up? I thought you.
> > 
> > But given you marked it as such -- Greg?
> 
> Technically, yes, Greg. I took the driver together with the I2C ATR
> feature because it was its first user. But other than that, it doesn't
> belong to the I2C realm. That being said, I can pick this patch to help
> removing the deprecated function if Greg doesn't pick it in the next
> days.

I can grab it later today, not a problem,

greg k-h