From: Tejun Heo <tj@kernel.org>
To: Chen Ridong <chenridong@huaweicloud.com>
Cc: "Michal Koutný" <mkoutny@suse.com>,
"Tiffany Yang" <ynaffit@google.com>,
linux-kernel@vger.kernel.org, "John Stultz" <jstultz@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Stephen Boyd" <sboyd@kernel.org>,
"Anna-Maria Behnsen" <anna-maria@linutronix.de>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Pavel Machek" <pavel@kernel.org>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Chen Ridong" <chenridong@huawei.com>,
kernel-team@android.com, "Jonathan Corbet" <corbet@lwn.net>,
cgroups@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: cpu.stat in core or cpu controller (was Re: [RFC PATCH v2] cgroup: Track time in cgroup v2 freezer)
Date: Thu, 24 Jul 2025 15:08:31 -1000 [thread overview]
Message-ID: <aILZDyD4mPkiMrfd@slm.duckdns.org> (raw)
In-Reply-To: <0064b782-2bed-4375-aba8-3745aa306a6d@huaweicloud.com>
On Wed, Jul 23, 2025 at 09:28:02AM +0800, Chen Ridong wrote:
> > But beware that the possibility of having cpu.stat without enabling the
> > cpu controller on v2 is a user visible behavior and I'm quite sure some
> > userspace relies on it, so you'd need to preserve that.
>
> This is what I worry about. Thank you for your confirmation.
Yeah, this was an intentional decision - sacrificing a bit of code org
cleanliness for everyday usefulness. Enabling CPU controller can have
substantial overhead and having cpu stats available by default doesn't cost
much while improving usefulness.
Thanks.
--
tejun
next prev parent reply other threads:[~2025-07-25 1:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 5:00 [RFC PATCH v2] cgroup: Track time in cgroup v2 freezer Tiffany Yang
2025-07-17 12:56 ` Michal Koutný
2025-07-17 13:52 ` Chen Ridong
2025-07-17 17:06 ` Tejun Heo
2025-07-22 22:41 ` Tiffany Yang
2025-07-22 22:27 ` Tiffany Yang
2025-07-17 17:05 ` Tejun Heo
2025-07-18 8:20 ` Michal Koutný
2025-07-18 9:26 ` Chen Ridong
2025-07-18 13:58 ` cpu.stat in core or cpu controller (was Re: [RFC PATCH v2] cgroup: Track time in cgroup v2 freezer) Michal Koutný
2025-07-19 2:01 ` Chen Ridong
2025-07-19 16:27 ` Tejun Heo
2025-07-22 9:01 ` Chen Ridong
2025-07-22 11:54 ` Michal Koutný
2025-07-23 1:28 ` Chen Ridong
2025-07-25 1:08 ` Tejun Heo [this message]
2025-07-25 1:54 ` Chen Ridong
2025-07-22 22:16 ` [RFC PATCH v2] cgroup: Track time in cgroup v2 freezer Tiffany Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aILZDyD4mPkiMrfd@slm.duckdns.org \
--to=tj@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@huawei.com \
--cc=chenridong@huaweicloud.com \
--cc=corbet@lwn.net \
--cc=frederic@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jstultz@google.com \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=ynaffit@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®