From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: <andersson@kernel.org>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <konradybcio@kernel.org>,
<rafael@kernel.org>, <viresh.kumar@linaro.org>,
<ilia.lin@kernel.org>, <djakov@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>,
"Sricharan Ramabadhran" <quic_srichara@quicinc.com>
Subject: Re: [PATCH v5 4/4] arm64: dts: qcom: ipq5424: Enable cpufreq
Date: Wed, 6 Aug 2025 17:01:10 +0530 [thread overview]
Message-ID: <aJM8/pA7X5KH1eJ/@hu-varada-blr.qualcomm.com> (raw)
In-Reply-To: <4890c832-3b78-4294-aaba-b62735f7934e@oss.qualcomm.com>
On Mon, Aug 04, 2025 at 02:33:12PM +0200, Konrad Dybcio wrote:
> On 8/4/25 1:20 PM, Varadarajan Narayanan wrote:
> > From: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> >
> > Add the qfprom, cpu clocks, A53 PLL and cpu-opp-table required for
> > CPU clock scaling.
> >
> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> > [ Added interconnect related entries, fix dt-bindings errors ]
> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> > ---
>
> [...]
>
> > + cpu_opp_table: opp-table-cpu {
> > + compatible = "operating-points-v2-kryo-cpu";
> > + opp-shared;
> > + nvmem-cells = <&cpu_speed_bin>;
> > +
> > + opp-816000000 {
> > + opp-hz = /bits/ 64 <816000000>;
> > + opp-microvolt = <1>;
>
> I just noticed this.. I don't think we have CPUs this efficient just yet
>
> Do we know some real values for these?
Have fixed these and other comments and posted v6. Please take a look.
Thanks
Varada
prev parent reply other threads:[~2025-08-06 11:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 11:20 [PATCH v5 0/4] Enable cpufreq for IPQ5424 Varadarajan Narayanan
2025-08-04 11:20 ` [PATCH v5 1/4] dt-bindings: clock: ipq5424-apss-clk: Add ipq5424 apss clock controller Varadarajan Narayanan
2025-08-05 5:16 ` Dmitry Baryshkov
2025-08-05 6:16 ` Krzysztof Kozlowski
2025-08-04 11:20 ` [PATCH v5 2/4] clk: qcom: apss-ipq5424: " Varadarajan Narayanan
2025-08-04 12:24 ` Konrad Dybcio
2025-08-04 11:20 ` [PATCH v5 3/4] cpufreq: qcom-nvmem: Enable cpufreq for ipq5424 Varadarajan Narayanan
2025-08-04 11:20 ` [PATCH v5 4/4] arm64: dts: qcom: ipq5424: Enable cpufreq Varadarajan Narayanan
2025-08-04 12:33 ` Konrad Dybcio
2025-08-06 11:31 ` Varadarajan Narayanan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJM8/pA7X5KH1eJ/@hu-varada-blr.qualcomm.com \
--to=quic_varada@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=ilia.lin@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_srichara@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®