* [PATCH] tee: optee: ffa: fix a typo of "optee_ffa_api_is_compatible"
@ 2025-08-06 12:47 Sungbae Yoo
2025-08-11 5:41 ` Sumit Garg
0 siblings, 1 reply; 7+ messages in thread
From: Sungbae Yoo @ 2025-08-06 12:47 UTC (permalink / raw)
To: Jens Wiklander, Sumit Garg, op-tee, linux-kernel
Fix: commit 4615e5a34b95 ("optee: add FF-A support")
Signed-off-by: Sungbae Yoo <sungbaey@nvidia.com>
diff --git a/drivers/tee/optee/ffa_abi.c b/drivers/tee/optee/ffa_abi.c
index f9ef7d94cebd..a963eed70c1d 100644
--- a/drivers/tee/optee/ffa_abi.c
+++ b/drivers/tee/optee/ffa_abi.c
@@ -657,7 +657,7 @@ static int optee_ffa_do_call_with_arg(struct tee_context *ctx,
* with a matching configuration.
*/
-static bool optee_ffa_api_is_compatbile(struct ffa_device *ffa_dev,
+static bool optee_ffa_api_is_compatible(struct ffa_device *ffa_dev,
const struct ffa_ops *ops)
{
const struct ffa_msg_ops *msg_ops = ops->msg_ops;
@@ -908,7 +908,7 @@ static int optee_ffa_probe(struct ffa_device *ffa_dev)
ffa_ops = ffa_dev->ops;
notif_ops = ffa_ops->notifier_ops;
- if (!optee_ffa_api_is_compatbile(ffa_dev, ffa_ops))
+ if (!optee_ffa_api_is_compatible(ffa_dev, ffa_ops))
return -EINVAL;
if (!optee_ffa_exchange_caps(ffa_dev, ffa_ops, &sec_caps,
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] tee: optee: ffa: fix a typo of "optee_ffa_api_is_compatible"
2025-08-06 12:47 [PATCH] tee: optee: ffa: fix a typo of "optee_ffa_api_is_compatible" Sungbae Yoo
@ 2025-08-11 5:41 ` Sumit Garg
2025-08-11 9:57 ` Sungbae Yoo
2025-08-11 10:00 ` Sungbae Yoo
0 siblings, 2 replies; 7+ messages in thread
From: Sumit Garg @ 2025-08-11 5:41 UTC (permalink / raw)
To: Sungbae Yoo; +Cc: Jens Wiklander, op-tee, linux-kernel
On Wed, Aug 06, 2025 at 12:47:35PM +0000, Sungbae Yoo wrote:
Add some commit description.
> Fix: commit 4615e5a34b95 ("optee: add FF-A support")
Correct fixes tag, should be instead:
Fixes: 4615e5a34b95 ("optee: add FF-A support")
-Sumit
> Signed-off-by: Sungbae Yoo <sungbaey@nvidia.com>
>
> diff --git a/drivers/tee/optee/ffa_abi.c b/drivers/tee/optee/ffa_abi.c
> index f9ef7d94cebd..a963eed70c1d 100644
> --- a/drivers/tee/optee/ffa_abi.c
> +++ b/drivers/tee/optee/ffa_abi.c
> @@ -657,7 +657,7 @@ static int optee_ffa_do_call_with_arg(struct tee_context *ctx,
> * with a matching configuration.
> */
>
> -static bool optee_ffa_api_is_compatbile(struct ffa_device *ffa_dev,
> +static bool optee_ffa_api_is_compatible(struct ffa_device *ffa_dev,
> const struct ffa_ops *ops)
> {
> const struct ffa_msg_ops *msg_ops = ops->msg_ops;
> @@ -908,7 +908,7 @@ static int optee_ffa_probe(struct ffa_device *ffa_dev)
> ffa_ops = ffa_dev->ops;
> notif_ops = ffa_ops->notifier_ops;
>
> - if (!optee_ffa_api_is_compatbile(ffa_dev, ffa_ops))
> + if (!optee_ffa_api_is_compatible(ffa_dev, ffa_ops))
> return -EINVAL;
>
> if (!optee_ffa_exchange_caps(ffa_dev, ffa_ops, &sec_caps,
> --
> 2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] tee: optee: ffa: fix a typo of "optee_ffa_api_is_compatible"
2025-08-11 5:41 ` Sumit Garg
@ 2025-08-11 9:57 ` Sungbae Yoo
2025-08-11 10:00 ` Sungbae Yoo
1 sibling, 0 replies; 7+ messages in thread
From: Sungbae Yoo @ 2025-08-11 9:57 UTC (permalink / raw)
To: Sumit Garg; +Cc: Jens Wiklander, op-tee, linux-kernel
On Mon, Aug 11, 2025 at 11:11:24AM +0530, Sumit Garg via OP-TEE wrote:
> On Wed, Aug 06, 2025 at 12:47:35PM +0000, Sungbae Yoo wrote:
>
> Add some commit description.
Will add the commit description like this :
Fixes optee_ffa_api_is_compatbile() to optee_ffa_api_is_compatible()
because compatbile is a typo of compatible.
>
> > Fix: commit 4615e5a34b95 ("optee: add FF-A support")
>
> Correct fixes tag, should be instead:
>
> Fixes: 4615e5a34b95 ("optee: add FF-A support")
Thank you for correcting this!
>
> -Sumit
>
> > Signed-off-by: Sungbae Yoo <sungbaey@nvidia.com>
> >
> > diff --git a/drivers/tee/optee/ffa_abi.c b/drivers/tee/optee/ffa_abi.c
> > index f9ef7d94cebd..a963eed70c1d 100644
> > --- a/drivers/tee/optee/ffa_abi.c
> > +++ b/drivers/tee/optee/ffa_abi.c
> > @@ -657,7 +657,7 @@ static int optee_ffa_do_call_with_arg(struct tee_context *ctx,
> > * with a matching configuration.
> > */
> >
> > -static bool optee_ffa_api_is_compatbile(struct ffa_device *ffa_dev,
> > +static bool optee_ffa_api_is_compatible(struct ffa_device *ffa_dev,
> > const struct ffa_ops *ops)
> > {
> > const struct ffa_msg_ops *msg_ops = ops->msg_ops;
> > @@ -908,7 +908,7 @@ static int optee_ffa_probe(struct ffa_device *ffa_dev)
> > ffa_ops = ffa_dev->ops;
> > notif_ops = ffa_ops->notifier_ops;
> >
> > - if (!optee_ffa_api_is_compatbile(ffa_dev, ffa_ops))
> > + if (!optee_ffa_api_is_compatible(ffa_dev, ffa_ops))
> > return -EINVAL;
> >
> > if (!optee_ffa_exchange_caps(ffa_dev, ffa_ops, &sec_caps,
> > --
> > 2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] tee: optee: ffa: fix a typo of "optee_ffa_api_is_compatible"
2025-08-11 5:41 ` Sumit Garg
2025-08-11 9:57 ` Sungbae Yoo
@ 2025-08-11 10:00 ` Sungbae Yoo
2025-08-11 10:43 ` Sumit Garg
1 sibling, 1 reply; 7+ messages in thread
From: Sungbae Yoo @ 2025-08-11 10:00 UTC (permalink / raw)
To: Sumit Garg; +Cc: Jens Wiklander, op-tee, linux-kernel
Fixes optee_ffa_api_is_compatbile() to optee_ffa_api_is_compatible()
because compatbile is a typo of compatible.
Fixes: 4615e5a34b95 ("optee: add FF-A support")
Signed-off-by: Sungbae Yoo <sungbaey@nvidia.com>
diff --git a/drivers/tee/optee/ffa_abi.c b/drivers/tee/optee/ffa_abi.c
index f9ef7d94cebd..a963eed70c1d 100644
--- a/drivers/tee/optee/ffa_abi.c
+++ b/drivers/tee/optee/ffa_abi.c
@@ -657,7 +657,7 @@ static int optee_ffa_do_call_with_arg(struct tee_context *ctx,
* with a matching configuration.
*/
-static bool optee_ffa_api_is_compatbile(struct ffa_device *ffa_dev,
+static bool optee_ffa_api_is_compatible(struct ffa_device *ffa_dev,
const struct ffa_ops *ops)
{
const struct ffa_msg_ops *msg_ops = ops->msg_ops;
@@ -908,7 +908,7 @@ static int optee_ffa_probe(struct ffa_device *ffa_dev)
ffa_ops = ffa_dev->ops;
notif_ops = ffa_ops->notifier_ops;
- if (!optee_ffa_api_is_compatbile(ffa_dev, ffa_ops))
+ if (!optee_ffa_api_is_compatible(ffa_dev, ffa_ops))
return -EINVAL;
if (!optee_ffa_exchange_caps(ffa_dev, ffa_ops, &sec_caps,
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] tee: optee: ffa: fix a typo of "optee_ffa_api_is_compatible"
2025-08-11 10:00 ` Sungbae Yoo
@ 2025-08-11 10:43 ` Sumit Garg
2025-08-11 11:31 ` Sungbae Yoo
0 siblings, 1 reply; 7+ messages in thread
From: Sumit Garg @ 2025-08-11 10:43 UTC (permalink / raw)
To: Sungbae Yoo; +Cc: Jens Wiklander, op-tee, linux-kernel
On Mon, Aug 11, 2025 at 10:00:17AM +0000, Sungbae Yoo wrote:
> Fixes optee_ffa_api_is_compatbile() to optee_ffa_api_is_compatible()
> because compatbile is a typo of compatible.
>
> Fixes: 4615e5a34b95 ("optee: add FF-A support")
>
This blank line should be dropped.
> Signed-off-by: Sungbae Yoo <sungbaey@nvidia.com>
>
With that fixed, feel free to apply:
Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
-Sumit
> diff --git a/drivers/tee/optee/ffa_abi.c b/drivers/tee/optee/ffa_abi.c
> index f9ef7d94cebd..a963eed70c1d 100644
> --- a/drivers/tee/optee/ffa_abi.c
> +++ b/drivers/tee/optee/ffa_abi.c
> @@ -657,7 +657,7 @@ static int optee_ffa_do_call_with_arg(struct tee_context *ctx,
> * with a matching configuration.
> */
>
> -static bool optee_ffa_api_is_compatbile(struct ffa_device *ffa_dev,
> +static bool optee_ffa_api_is_compatible(struct ffa_device *ffa_dev,
> const struct ffa_ops *ops)
> {
> const struct ffa_msg_ops *msg_ops = ops->msg_ops;
> @@ -908,7 +908,7 @@ static int optee_ffa_probe(struct ffa_device *ffa_dev)
> ffa_ops = ffa_dev->ops;
> notif_ops = ffa_ops->notifier_ops;
>
> - if (!optee_ffa_api_is_compatbile(ffa_dev, ffa_ops))
> + if (!optee_ffa_api_is_compatible(ffa_dev, ffa_ops))
> return -EINVAL;
>
> if (!optee_ffa_exchange_caps(ffa_dev, ffa_ops, &sec_caps,
> --
> 2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] tee: optee: ffa: fix a typo of "optee_ffa_api_is_compatible"
2025-08-11 10:43 ` Sumit Garg
@ 2025-08-11 11:31 ` Sungbae Yoo
2025-08-14 8:00 ` Jens Wiklander
0 siblings, 1 reply; 7+ messages in thread
From: Sungbae Yoo @ 2025-08-11 11:31 UTC (permalink / raw)
To: Sumit Garg; +Cc: Jens Wiklander, op-tee, linux-kernel
Fixes optee_ffa_api_is_compatbile() to optee_ffa_api_is_compatible()
because compatbile is a typo of compatible.
Fixes: 4615e5a34b95 ("optee: add FF-A support")
Signed-off-by: Sungbae Yoo <sungbaey@nvidia.com>
Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
diff --git a/drivers/tee/optee/ffa_abi.c b/drivers/tee/optee/ffa_abi.c
index f9ef7d94cebd..a963eed70c1d 100644
--- a/drivers/tee/optee/ffa_abi.c
+++ b/drivers/tee/optee/ffa_abi.c
@@ -657,7 +657,7 @@ static int optee_ffa_do_call_with_arg(struct tee_context *ctx,
* with a matching configuration.
*/
-static bool optee_ffa_api_is_compatbile(struct ffa_device *ffa_dev,
+static bool optee_ffa_api_is_compatible(struct ffa_device *ffa_dev,
const struct ffa_ops *ops)
{
const struct ffa_msg_ops *msg_ops = ops->msg_ops;
@@ -908,7 +908,7 @@ static int optee_ffa_probe(struct ffa_device *ffa_dev)
ffa_ops = ffa_dev->ops;
notif_ops = ffa_ops->notifier_ops;
- if (!optee_ffa_api_is_compatbile(ffa_dev, ffa_ops))
+ if (!optee_ffa_api_is_compatible(ffa_dev, ffa_ops))
return -EINVAL;
if (!optee_ffa_exchange_caps(ffa_dev, ffa_ops, &sec_caps,
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] tee: optee: ffa: fix a typo of "optee_ffa_api_is_compatible"
2025-08-11 11:31 ` Sungbae Yoo
@ 2025-08-14 8:00 ` Jens Wiklander
0 siblings, 0 replies; 7+ messages in thread
From: Jens Wiklander @ 2025-08-14 8:00 UTC (permalink / raw)
To: Sungbae Yoo; +Cc: Sumit Garg, op-tee, linux-kernel
On Mon, Aug 11, 2025 at 1:31 PM Sungbae Yoo <sungbaey@nvidia.com> wrote:
>
> Fixes optee_ffa_api_is_compatbile() to optee_ffa_api_is_compatible()
> because compatbile is a typo of compatible.
>
> Fixes: 4615e5a34b95 ("optee: add FF-A support")
> Signed-off-by: Sungbae Yoo <sungbaey@nvidia.com>
> Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
>
Looks good. I'm picking up this.
Thanks,
Jens
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-08-14 8:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-06 12:47 [PATCH] tee: optee: ffa: fix a typo of "optee_ffa_api_is_compatible" Sungbae Yoo
2025-08-11 5:41 ` Sumit Garg
2025-08-11 9:57 ` Sungbae Yoo
2025-08-11 10:00 ` Sungbae Yoo
2025-08-11 10:43 ` Sumit Garg
2025-08-11 11:31 ` Sungbae Yoo
2025-08-14 8:00 ` Jens Wiklander
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®