From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] iio: adc: ad7124: add clock output support
Date: Tue, 26 Aug 2025 18:32:38 +0300 [thread overview]
Message-ID: <aK3TlqSTo2AXbB1K@smile.fi.intel.com> (raw)
In-Reply-To: <181dafaa-ec04-43cd-b0a4-208da8cd89e9@baylibre.com>
On Tue, Aug 26, 2025 at 10:11:09AM -0500, David Lechner wrote:
> On 8/26/25 3:13 AM, Andy Shevchenko wrote:
> > On Tue, Aug 26, 2025 at 1:55 AM David Lechner <dlechner@baylibre.com> wrote:
...
> >> static const int ad7124_master_clk_freq_hz[3] = {
> >> - [AD7124_LOW_POWER] = 76800,
> >> - [AD7124_MID_POWER] = 153600,
> >> - [AD7124_FULL_POWER] = 614400,
> >> + [AD7124_LOW_POWER] = AD7124_INT_CLK_HZ / 8,
> >> + [AD7124_MID_POWER] = AD7124_INT_CLK_HZ / 4,
> >> + [AD7124_FULL_POWER] = AD7124_INT_CLK_HZ,
> >
> > Perhaps / 1 ?
>
> Seems redundant.
Yes and no. I think that it makes sense to put for the consistency as it makes
reader aware of the divisors. 1 is also valid divisor after all.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-08-26 15:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 22:54 [PATCH v2 0/4] iio: adc: ad7124: proper clock support David Lechner
2025-08-25 22:55 ` [PATCH v2 1/4] dt-bindings: iio: adc: adi,ad7124: fix clocks properties David Lechner
2025-08-25 22:55 ` [PATCH v2 2/4] iio: adc: ad7124: do not require mclk David Lechner
2025-08-25 22:55 ` [PATCH v2 3/4] iio: adc: ad7124: add external clock support David Lechner
2025-08-26 8:10 ` Andy Shevchenko
2025-08-26 15:17 ` David Lechner
2025-08-25 22:55 ` [PATCH v2 4/4] iio: adc: ad7124: add clock output support David Lechner
2025-08-26 8:13 ` Andy Shevchenko
2025-08-26 15:11 ` David Lechner
2025-08-26 15:32 ` Andy Shevchenko [this message]
2025-08-26 9:21 ` kernel test robot
2025-08-26 16:02 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aK3TlqSTo2AXbB1K@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®