From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kernel Janitors <kernel-janitors@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Yang Yingliang <yangyingliang@huawei.com>,
Lee Jones <lee@kernel.org>, Randy Dunlap <rdunlap@infradead.org>,
Shaomin Deng <dengshaomin@cdjrlc.com>,
Jilin Yuan <yuanjilin@cdjrlc.com>, Mao Zhu <zhumao001@208suo.com>
Subject: Re: [PATCH] pcmcia: ds: Emphasize "really" epizeuxis
Date: Sat, 16 Aug 2025 16:42:31 +0200 [thread overview]
Message-ID: <aKCY182EIzEZCV4P@shine.dominikbrodowski.net> (raw)
In-Reply-To: <20250811020436.13486-2-bagasdotme@gmail.com>
Applied to pcmcia-next.
Thanks,
Dominik
Am Mon, Aug 11, 2025 at 09:04:37AM +0700 schrieb Bagas Sanjaya:
> pcmcia_dev_present() comment writes about small timeframe where
> the function returns NULL (racy condition), in epizeuxis device. In the
> past, it tripped contributors who misunderstood it for "really"
> duplicate ([1], [2]).
>
> Add comma between "really" words to emphasize the epizeuxis.
>
> Link: https://lore.kernel.org/all/YxT1As38WRZcyH0%2F@shine.dominikbrodowski.net/ [1]
> Link: https://lore.kernel.org/all/20220831083623.GA25639@isilmar-4.linta.de/ [2]
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
> drivers/pcmcia/ds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pcmcia/ds.c b/drivers/pcmcia/ds.c
> index da6f66f357cc10..18f4eef28dbc5d 100644
> --- a/drivers/pcmcia/ds.c
> +++ b/drivers/pcmcia/ds.c
> @@ -1308,7 +1308,7 @@ static int pcmcia_bus_early_resume(struct pcmcia_socket *skt)
> * physically present, even if the call to this function returns
> * non-NULL. Furthermore, the device driver most likely is unbound
> * almost immediately, so the timeframe where pcmcia_dev_present
> - * returns NULL is probably really really small.
> + * returns NULL is probably really, really small.
> */
> struct pcmcia_device *pcmcia_dev_present(struct pcmcia_device *_p_dev)
> {
>
> base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
> --
> An old man doll... just what I always wanted! - Clara
>
>
prev parent reply other threads:[~2025-08-16 14:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 2:04 Bagas Sanjaya
2025-08-16 14:42 ` Dominik Brodowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKCY182EIzEZCV4P@shine.dominikbrodowski.net \
--to=linux@dominikbrodowski.net \
--cc=bagasdotme@gmail.com \
--cc=dengshaomin@cdjrlc.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=yangyingliang@huawei.com \
--cc=yuanjilin@cdjrlc.com \
--cc=zhumao001@208suo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®