From: Herbert Xu <herbert@gondor.apana.org.au>
To: Edward Adam Davis <eadavis@qq.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+e8bcd7ee3db6cb5cb875@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH V2] crypto: Mark intermediary memory as clean
Date: Mon, 18 Aug 2025 20:30:29 +0800 [thread overview]
Message-ID: <aKMc5amKH9CLbKL8@gondor.apana.org.au> (raw)
In-Reply-To: <tencent_50604BE61B0A2525BA07BB9033239E401B08@qq.com>
On Mon, Aug 18, 2025 at 08:17:17PM +0800, Edward Adam Davis wrote:
>
> Their values are equal, so why use sizeof to calculate?
> Similarly, "if (sizeof(intermediary) != crypto_shash_digestsize(desc->tfm)) {",
> why not just use SHA3_256_DIGEST_SIZE?
Please be consistent with the existing code, every other place
in the function uses sizeof(intermediary) so your patch is the
odd one out.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-08-18 12:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 8:07 [syzbot] [crypto?] KMSAN: kernel-infoleak in rng_recvmsg syzbot
2025-08-09 7:19 ` Edward Adam Davis
2025-08-09 9:52 ` syzbot
2025-08-09 9:59 ` [PATCH] crypto: Prevent " Edward Adam Davis
2025-08-16 9:17 ` Herbert Xu
2025-08-17 8:51 ` Herbert Xu
2025-08-17 10:59 ` [PATCH V2] crypto: Mark intermediary memory as clean Edward Adam Davis
2025-08-17 11:40 ` Herbert Xu
2025-08-18 12:17 ` Edward Adam Davis
2025-08-18 12:30 ` Herbert Xu [this message]
2025-08-18 12:43 ` Edward Adam Davis
2025-08-18 13:13 ` Stephan Mueller
2025-08-18 13:24 ` [PATCH V3] " Edward Adam Davis
2025-08-18 13:32 ` Stephan Mueller
2025-08-30 8:45 ` Herbert Xu
2025-08-26 13:51 ` [PATCH] crypto: Prevent kernel-infoleak in rng_recvmsg Ard Biesheuvel
2025-08-26 16:58 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKMc5amKH9CLbKL8@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=eadavis@qq.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+e8bcd7ee3db6cb5cb875@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®