From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Zhang Heng <zhangheng@kylinos.cn>
Cc: axboe@kernel.dk, phasta@kernel.org, broonie@kernel.org,
lizetao1@huawei.com, viro@zeniv.linux.org.uk,
fourier.thomas@gmail.com, anuj20.g@samsung.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: mtip32xx: Remove the redundant return
Date: Fri, 22 Aug 2025 12:36:07 +0300 [thread overview]
Message-ID: <aKg6B6buH5xYlnxL@smile.fi.intel.com> (raw)
In-Reply-To: <20250822024100.991144-1-zhangheng@kylinos.cn>
On Fri, Aug 22, 2025 at 10:41:00AM +0800, Zhang Heng wrote:
> Remove the redundant return
Missing period.
...
> iomap_err:
> kfree(dd);
> pci_set_drvdata(pdev, NULL);
I'm wondering if this also being redundant. I know about some corner cases, so
is this one of them, or can it be removed as well?
> - return rv;
> done:
> return rv;
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-08-22 9:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 2:41 Zhang Heng
2025-08-22 9:36 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKg6B6buH5xYlnxL@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=fourier.thomas@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=phasta@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zhangheng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®