* [PATCH] block: mtip32xx: Remove the redundant return
@ 2025-08-22 2:41 Zhang Heng
2025-08-22 9:36 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Heng @ 2025-08-22 2:41 UTC (permalink / raw)
To: axboe, phasta, andriy.shevchenko, broonie, lizetao1, viro,
fourier.thomas, anuj20.g
Cc: linux-block, linux-kernel, Zhang Heng
Remove the redundant return
Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
---
drivers/block/mtip32xx/mtip32xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 8fc7761397bd..b0c4d1c92da5 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -3841,7 +3841,6 @@ static int mtip_pci_probe(struct pci_dev *pdev,
iomap_err:
kfree(dd);
pci_set_drvdata(pdev, NULL);
- return rv;
done:
return rv;
}
--
2.47.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] block: mtip32xx: Remove the redundant return
2025-08-22 2:41 [PATCH] block: mtip32xx: Remove the redundant return Zhang Heng
@ 2025-08-22 9:36 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2025-08-22 9:36 UTC (permalink / raw)
To: Zhang Heng
Cc: axboe, phasta, broonie, lizetao1, viro, fourier.thomas, anuj20.g,
linux-block, linux-kernel
On Fri, Aug 22, 2025 at 10:41:00AM +0800, Zhang Heng wrote:
> Remove the redundant return
Missing period.
...
> iomap_err:
> kfree(dd);
> pci_set_drvdata(pdev, NULL);
I'm wondering if this also being redundant. I know about some corner cases, so
is this one of them, or can it be removed as well?
> - return rv;
> done:
> return rv;
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-22 9:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-22 2:41 [PATCH] block: mtip32xx: Remove the redundant return Zhang Heng
2025-08-22 9:36 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®