From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Adrian Barnaś" <abarnas@google.com>
Cc: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 2/2] staging:media: atomisp: Whitespaces cleanup in vmem.c
Date: Mon, 1 Sep 2025 18:37:58 +0300 [thread overview]
Message-ID: <aLW91kNOfi1ab6D3@smile.fi.intel.com> (raw)
In-Reply-To: <CAATBrPHpLnsWb-Ua0z2Nmv7To_yXeosoV8+nGzcWfGUVPFq1Xg@mail.gmail.com>
On Mon, Sep 01, 2025 at 02:46:47PM +0200, Adrian Barnaś wrote:
> On Mon, Sep 1, 2025 at 2:23 PM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > On Mon, Sep 01, 2025 at 09:10:50AM +0000, Adrian Barnaś wrote:
> > > Whitespaces cleanup to conform with kernel style and improve readability.
> > Strange...
>
> You mean the commit description? Should I reword it?
No, the case I explained below.
> > Note, the style after the first patch is okay. I dunno what's wrong with it.
>
> Those were not violate the kernel code style indeed, but it looks more
> consistent this way for me.
> Should I revert those?
If you are talking about the second patch changes in the same functions, yes,
please, keep them untouched _after_ the patch 1.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-09-01 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 9:10 [PATCH 0/2] staging: media: atomisp: Style fixes for vmem.c Adrian Barnaś
2025-09-01 9:10 ` [PATCH 1/2] staging: media: atomisp: Remove typedefs for basic types in vmem.c Adrian Barnaś
2025-09-01 12:35 ` Andy Shevchenko
2025-09-01 13:27 ` Adrian Barnaś
2025-09-01 15:42 ` Andy Shevchenko
2025-09-01 9:10 ` [PATCH 2/2] staging:media: atomisp: Whitespaces cleanup " Adrian Barnaś
2025-09-01 12:23 ` Andy Shevchenko
2025-09-01 12:46 ` Adrian Barnaś
2025-09-01 15:37 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLW91kNOfi1ab6D3@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=abarnas@google.com \
--cc=andy@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®