Re: [PATCH 2/2] staging:media: atomisp: Whitespaces cleanup in vmem.c

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Mon, Sep 01, 2025 at 09:10:50AM +0000, Adrian Barnaś wrote:
> Whitespaces cleanup to conform with kernel style and improve readability.

Strange...

...

>  /* subword bits move like this:         MSB[____xxxx____]LSB -> MSB[00000000xxxx]LSB */
> -static inline unsigned long long
> -subword(unsigned long long w, unsigned int start, unsigned int end)
> +static inline unsigned long long subword(unsigned long long w, unsigned int start,
> +					 unsigned int end)
>  {
>  	return (w & (((1ULL << (end - 1)) - 1) << 1 | 1)) >> start;
>  }
>  
>  /* inverse subword bits move like this: MSB[xxxx____xxxx]LSB -> MSB[xxxx0000xxxx]LSB */
> -static inline unsigned long long
> -inv_subword(unsigned long long w, unsigned int start, unsigned int end)
> +static inline unsigned long long inv_subword(unsigned long long w, unsigned int start,
> +					     unsigned int end)
>  {
>  	return w & (~(((1ULL << (end - 1)) - 1) << 1 | 1) | ((1ULL << start) - 1));
>  }

These two were just "fixed according to the kernel coding style" and here
again. This is odd.

Note, the style after the first patch is okay. I dunno what's wrong with it.

...

> -void isp_vmem_load(
> -    const isp_ID_t		ID,
> -    const t_vmem_elem	*from,
> -    t_vmem_elem		*to,
> -    unsigned int elems) /* In t_vmem_elem */
> +void isp_vmem_load(const isp_ID_t ID, const t_vmem_elem *from, t_vmem_elem *to,
> +		   unsigned int elems) /* In t_vmem_elem */

Please, (re)move trailing comments somewhere else.

-- 
With Best Regards,
Andy Shevchenko