* [PATCH] drm/gud: fix accidentally deleted IS_ERR() check [not found] <20250922173836.5608-1-rubenru09.ref@aol.com> @ 2025-09-22 17:32 ` Ruben Wauters 2025-09-23 6:38 ` Thomas Zimmermann 2025-09-23 7:57 ` Thomas Zimmermann 0 siblings, 2 replies; 6+ messages in thread From: Ruben Wauters @ 2025-09-22 17:32 UTC (permalink / raw) To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter Cc: Ruben Wauters, Dan Carpenter, lkp, oe-kbuild, oe-kbuild-all, dri-devel, linux-kernel During conversion of WARN_ON_ONCE to drm_WARN_ON_ONCE in commit 2d2f1dc74cfb ("drm: gud: replace WARN_ON/WARN_ON_ONCE with drm versions"), the IS_ERR check was accidentally removed, breaking the gud_connector_add_properties() function, as any valid pointer in state_val would produce an error. The warning was reported by kernel test robot, and is fixed in this patch. Fixes: 2d2f1dc74cfb ("drm: gud: replace WARN_ON/WARN_ON_ONCE with drm versions") Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/r/202509212215.c8v3RKmL-lkp@intel.com/ Signed-off-by: Ruben Wauters <rubenru09@aol.com> --- drivers/gpu/drm/gud/gud_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gud/gud_connector.c b/drivers/gpu/drm/gud/gud_connector.c index 62e349b06dbe..1726a3fadff8 100644 --- a/drivers/gpu/drm/gud/gud_connector.c +++ b/drivers/gpu/drm/gud/gud_connector.c @@ -593,7 +593,7 @@ int gud_connector_fill_properties(struct drm_connector_state *connector_state, unsigned int *state_val; state_val = gud_connector_tv_state_val(prop, &connector_state->tv); - if (drm_WARN_ON_ONCE(connector_state->connector->dev, state_val)) + if (drm_WARN_ON_ONCE(connector_state->connector->dev, IS_ERR(state_val))) return PTR_ERR(state_val); val = *state_val; -- 2.49.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/gud: fix accidentally deleted IS_ERR() check 2025-09-22 17:32 ` [PATCH] drm/gud: fix accidentally deleted IS_ERR() check Ruben Wauters @ 2025-09-23 6:38 ` Thomas Zimmermann 2025-09-23 7:57 ` Thomas Zimmermann 1 sibling, 0 replies; 6+ messages in thread From: Thomas Zimmermann @ 2025-09-23 6:38 UTC (permalink / raw) To: Ruben Wauters, Maarten Lankhorst, Maxime Ripard, David Airlie, Simona Vetter Cc: Dan Carpenter, lkp, oe-kbuild, oe-kbuild-all, dri-devel, linux-kernel Am 22.09.25 um 19:32 schrieb Ruben Wauters: > During conversion of WARN_ON_ONCE to drm_WARN_ON_ONCE in commit > 2d2f1dc74cfb ("drm: gud: replace WARN_ON/WARN_ON_ONCE with drm > versions"), the IS_ERR check was accidentally removed, breaking the > gud_connector_add_properties() function, as any valid pointer in > state_val would produce an error. > > The warning was reported by kernel test robot, and is fixed in this patch. > > Fixes: 2d2f1dc74cfb ("drm: gud: replace WARN_ON/WARN_ON_ONCE with drm versions") > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/r/202509212215.c8v3RKmL-lkp@intel.com/ > Signed-off-by: Ruben Wauters <rubenru09@aol.com> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > drivers/gpu/drm/gud/gud_connector.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/gud/gud_connector.c b/drivers/gpu/drm/gud/gud_connector.c > index 62e349b06dbe..1726a3fadff8 100644 > --- a/drivers/gpu/drm/gud/gud_connector.c > +++ b/drivers/gpu/drm/gud/gud_connector.c > @@ -593,7 +593,7 @@ int gud_connector_fill_properties(struct drm_connector_state *connector_state, > unsigned int *state_val; > > state_val = gud_connector_tv_state_val(prop, &connector_state->tv); > - if (drm_WARN_ON_ONCE(connector_state->connector->dev, state_val)) > + if (drm_WARN_ON_ONCE(connector_state->connector->dev, IS_ERR(state_val))) > return PTR_ERR(state_val); > > val = *state_val; -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/gud: fix accidentally deleted IS_ERR() check 2025-09-22 17:32 ` [PATCH] drm/gud: fix accidentally deleted IS_ERR() check Ruben Wauters 2025-09-23 6:38 ` Thomas Zimmermann @ 2025-09-23 7:57 ` Thomas Zimmermann 2025-09-23 8:29 ` Dan Carpenter 2025-09-23 9:38 ` Ruben Wauters 1 sibling, 2 replies; 6+ messages in thread From: Thomas Zimmermann @ 2025-09-23 7:57 UTC (permalink / raw) To: Ruben Wauters, Maarten Lankhorst, Maxime Ripard, David Airlie, Simona Vetter Cc: Dan Carpenter, lkp, oe-kbuild, oe-kbuild-all, dri-devel, linux-kernel FYI I got the following warnings. I'll fix them when I merge the patch. -:6: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 2d2f1dc74cfb ("drm: gud: replace WARN_ON/WARN_ON_ONCE with drm versions")' #6: During conversion of WARN_ON_ONCE to drm_WARN_ON_ONCE in commit -:15: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report #15: Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Am 22.09.25 um 19:32 schrieb Ruben Wauters: > During conversion of WARN_ON_ONCE to drm_WARN_ON_ONCE in commit > 2d2f1dc74cfb ("drm: gud: replace WARN_ON/WARN_ON_ONCE with drm > versions"), the IS_ERR check was accidentally removed, breaking the > gud_connector_add_properties() function, as any valid pointer in > state_val would produce an error. > > The warning was reported by kernel test robot, and is fixed in this patch. > > Fixes: 2d2f1dc74cfb ("drm: gud: replace WARN_ON/WARN_ON_ONCE with drm versions") > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/r/202509212215.c8v3RKmL-lkp@intel.com/ > Signed-off-by: Ruben Wauters <rubenru09@aol.com> > --- > drivers/gpu/drm/gud/gud_connector.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/gud/gud_connector.c b/drivers/gpu/drm/gud/gud_connector.c > index 62e349b06dbe..1726a3fadff8 100644 > --- a/drivers/gpu/drm/gud/gud_connector.c > +++ b/drivers/gpu/drm/gud/gud_connector.c > @@ -593,7 +593,7 @@ int gud_connector_fill_properties(struct drm_connector_state *connector_state, > unsigned int *state_val; > > state_val = gud_connector_tv_state_val(prop, &connector_state->tv); > - if (drm_WARN_ON_ONCE(connector_state->connector->dev, state_val)) > + if (drm_WARN_ON_ONCE(connector_state->connector->dev, IS_ERR(state_val))) > return PTR_ERR(state_val); > > val = *state_val; -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/gud: fix accidentally deleted IS_ERR() check 2025-09-23 7:57 ` Thomas Zimmermann @ 2025-09-23 8:29 ` Dan Carpenter 2025-09-23 9:38 ` Ruben Wauters 1 sibling, 0 replies; 6+ messages in thread From: Dan Carpenter @ 2025-09-23 8:29 UTC (permalink / raw) To: Thomas Zimmermann Cc: Ruben Wauters, Maarten Lankhorst, Maxime Ripard, David Airlie, Simona Vetter, lkp, oe-kbuild, oe-kbuild-all, dri-devel, linux-kernel On Tue, Sep 23, 2025 at 09:57:11AM +0200, Thomas Zimmermann wrote: > -:15: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately > followed by Closes: with a URL to the report > #15: > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > I've been meaning to add a lkp@intel.com exception to that rule in checkpatch... :/ regards, dan carpenter ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/gud: fix accidentally deleted IS_ERR() check 2025-09-23 7:57 ` Thomas Zimmermann 2025-09-23 8:29 ` Dan Carpenter @ 2025-09-23 9:38 ` Ruben Wauters 2025-09-23 11:59 ` Thomas Zimmermann 1 sibling, 1 reply; 6+ messages in thread From: Ruben Wauters @ 2025-09-23 9:38 UTC (permalink / raw) To: Thomas Zimmermann, Maarten Lankhorst, Maxime Ripard, David Airlie, Simona Vetter Cc: Dan Carpenter, lkp, oe-kbuild, oe-kbuild-all, dri-devel, linux-kernel On Tue, 2025-09-23 at 09:57 +0200, Thomas Zimmermann wrote: > FYI I got the following warnings. I'll fix them when I merge the > patch. > > -:6: ERROR:GIT_COMMIT_ID: Please use git commit description style > 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit > 2d2f1dc74cfb > ("drm: gud: replace WARN_ON/WARN_ON_ONCE with drm versions")' > #6: > During conversion of WARN_ON_ONCE to drm_WARN_ON_ONCE in commit I'm not 100% sure why it's complaining about this one, the format matches. I assume it's a problem with the line break in it? but I'm not 100% sure. > -:15: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be > immediately > followed by Closes: with a URL to the report > #15: > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> I believe it's intentional to have two reported bys in a row, as both of them are followed by a Closes tag at the end. Thanks > Am 22.09.25 um 19:32 schrieb Ruben Wauters: > > During conversion of WARN_ON_ONCE to drm_WARN_ON_ONCE in commit > > 2d2f1dc74cfb ("drm: gud: replace WARN_ON/WARN_ON_ONCE with drm > > versions"), the IS_ERR check was accidentally removed, breaking the > > gud_connector_add_properties() function, as any valid pointer in > > state_val would produce an error. > > > > The warning was reported by kernel test robot, and is fixed in this > > patch. > > > > Fixes: 2d2f1dc74cfb ("drm: gud: replace WARN_ON/WARN_ON_ONCE with > > drm versions") > > Reported-by: kernel test robot <lkp@intel.com> > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > > Closes: > > https://lore.kernel.org/r/202509212215.c8v3RKmL-lkp@intel.com/ > > Signed-off-by: Ruben Wauters <rubenru09@aol.com> > > --- > > drivers/gpu/drm/gud/gud_connector.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/gud/gud_connector.c > > b/drivers/gpu/drm/gud/gud_connector.c > > index 62e349b06dbe..1726a3fadff8 100644 > > --- a/drivers/gpu/drm/gud/gud_connector.c > > +++ b/drivers/gpu/drm/gud/gud_connector.c > > @@ -593,7 +593,7 @@ int gud_connector_fill_properties(struct > > drm_connector_state *connector_state, > > unsigned int *state_val; > > > > state_val = > > gud_connector_tv_state_val(prop, &connector_state->tv); > > - if (drm_WARN_ON_ONCE(connector_state- > > >connector->dev, state_val)) > > + if (drm_WARN_ON_ONCE(connector_state- > > >connector->dev, IS_ERR(state_val))) > > return PTR_ERR(state_val); > > > > val = *state_val; ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/gud: fix accidentally deleted IS_ERR() check 2025-09-23 9:38 ` Ruben Wauters @ 2025-09-23 11:59 ` Thomas Zimmermann 0 siblings, 0 replies; 6+ messages in thread From: Thomas Zimmermann @ 2025-09-23 11:59 UTC (permalink / raw) To: Ruben Wauters, Maarten Lankhorst, Maxime Ripard, David Airlie, Simona Vetter Cc: Dan Carpenter, lkp, oe-kbuild, oe-kbuild-all, dri-devel, linux-kernel Hi Am 23.09.25 um 11:38 schrieb Ruben Wauters: > On Tue, 2025-09-23 at 09:57 +0200, Thomas Zimmermann wrote: >> FYI I got the following warnings. I'll fix them when I merge the >> patch. >> >> -:6: ERROR:GIT_COMMIT_ID: Please use git commit description style >> 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit >> 2d2f1dc74cfb >> ("drm: gud: replace WARN_ON/WARN_ON_ONCE with drm versions")' >> #6: >> During conversion of WARN_ON_ONCE to drm_WARN_ON_ONCE in commit > I'm not 100% sure why it's complaining about this one, the format > matches. I assume it's a problem with the line break in it? but I'm not > 100% sure. > >> -:15: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be >> immediately >> followed by Closes: with a URL to the report >> #15: >> Reported-by: kernel test robot <lkp@intel.com> >> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > I believe it's intentional to have two reported bys in a row, as both > of them are followed by a Closes tag at the end. Neither warning is really your fault. As you say the script doesn't like line breaks in certain places. It also only wants pairs of Closes/R-b tags. Best regards Thomas > > Thanks > >> Am 22.09.25 um 19:32 schrieb Ruben Wauters: >>> During conversion of WARN_ON_ONCE to drm_WARN_ON_ONCE in commit >>> 2d2f1dc74cfb ("drm: gud: replace WARN_ON/WARN_ON_ONCE with drm >>> versions"), the IS_ERR check was accidentally removed, breaking the >>> gud_connector_add_properties() function, as any valid pointer in >>> state_val would produce an error. >>> >>> The warning was reported by kernel test robot, and is fixed in this >>> patch. >>> >>> Fixes: 2d2f1dc74cfb ("drm: gud: replace WARN_ON/WARN_ON_ONCE with >>> drm versions") >>> Reported-by: kernel test robot <lkp@intel.com> >>> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> >>> Closes: >>> https://lore.kernel.org/r/202509212215.c8v3RKmL-lkp@intel.com/ >>> Signed-off-by: Ruben Wauters <rubenru09@aol.com> >>> --- >>> drivers/gpu/drm/gud/gud_connector.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/gud/gud_connector.c >>> b/drivers/gpu/drm/gud/gud_connector.c >>> index 62e349b06dbe..1726a3fadff8 100644 >>> --- a/drivers/gpu/drm/gud/gud_connector.c >>> +++ b/drivers/gpu/drm/gud/gud_connector.c >>> @@ -593,7 +593,7 @@ int gud_connector_fill_properties(struct >>> drm_connector_state *connector_state, >>> unsigned int *state_val; >>> >>> state_val = >>> gud_connector_tv_state_val(prop, &connector_state->tv); >>> - if (drm_WARN_ON_ONCE(connector_state- >>>> connector->dev, state_val)) >>> + if (drm_WARN_ON_ONCE(connector_state- >>>> connector->dev, IS_ERR(state_val))) >>> return PTR_ERR(state_val); >>> >>> val = *state_val; -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg) ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-09-23 11:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20250922173836.5608-1-rubenru09.ref@aol.com>
2025-09-22 17:32 ` [PATCH] drm/gud: fix accidentally deleted IS_ERR() check Ruben Wauters
2025-09-23 6:38 ` Thomas Zimmermann
2025-09-23 7:57 ` Thomas Zimmermann
2025-09-23 8:29 ` Dan Carpenter
2025-09-23 9:38 ` Ruben Wauters
2025-09-23 11:59 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®