* Re: [PATCH] [patch] syz test
[not found] <6fnt99vd47a5-6fo0chqsqcpq@nsmail8.2--kylin--1>
@ 2025-10-21 5:25 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2025-10-21 5:25 UTC (permalink / raw)
To: 肖沛
Cc: syzbot+01fcd39a0d90cdb0e3df, davem, linux-crypto, linux-kernel,
syzkaller-bugs
On Tue, Oct 21, 2025 at 01:16:06PM +0800, 肖沛 wrote:
>
> <pre id="b" style="font-size: 13px; font-family: monospace; background: #ffffff; color: #000033; white-space: pre-wrap; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;">but now syzbot has tested the proposed patch and the reproducer did not trigger any issue
> after modified.</pre>
Please stop sending html emails.
Yes please submit the patch properly to lib/crypto:
CRYPTO LIBRARY
M: Eric Biggers <ebiggers@kernel.org>
M: Jason A. Donenfeld <Jason@zx2c4.com>
M: Ard Biesheuvel <ardb@kernel.org>
L: linux-crypto@vger.kernel.org
S: Maintained
T: git https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git libcrypto-next
T: git https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git libcrypto-fixes
F: lib/crypto/
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [patch] syz test
2025-10-21 3:08 ` [PATCH] [patch] syz test Pei Xiao
@ 2025-10-21 3:12 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2025-10-21 3:12 UTC (permalink / raw)
To: Pei Xiao
Cc: syzbot+01fcd39a0d90cdb0e3df, davem, linux-crypto, linux-kernel,
syzkaller-bugs
On Tue, Oct 21, 2025 at 11:08:54AM +0800, Pei Xiao wrote:
> #syz test
> ---
> lib/crypto/x86/poly1305.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/crypto/x86/poly1305.h b/lib/crypto/x86/poly1305.h
> index ee92e3740a78..3b9f1024a18d 100644
> --- a/lib/crypto/x86/poly1305.h
> +++ b/lib/crypto/x86/poly1305.h
> @@ -8,6 +8,7 @@
> #include <linux/jump_label.h>
> #include <linux/kernel.h>
> #include <linux/sizes.h>
> +#include <linux/string.h>
>
> struct poly1305_arch_internal {
> union {
> @@ -86,6 +87,7 @@ static __ro_after_init DEFINE_STATIC_KEY_FALSE(poly1305_use_avx512);
> static void poly1305_block_init(struct poly1305_block_state *state,
> const u8 raw_key[POLY1305_BLOCK_SIZE])
> {
> + memset(state, 0, sizeof(struct poly1305_block_state));
> poly1305_init_x86_64(state, raw_key);
> }
Please stop sending random patches to me. If you want to test
random patches, send it to syzbot only and not anyone else.
When you hit an uninitialised access in crypto code, it's usually
the caller at fault. So I suggest that you focus your energies
further up the stack.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] [patch] syz test
2025-10-21 2:51 [syzbot] [crypto?] KMSAN: uninit-value in poly1305_blocks syzbot
@ 2025-10-21 3:08 ` Pei Xiao
2025-10-21 3:12 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: Pei Xiao @ 2025-10-21 3:08 UTC (permalink / raw)
To: syzbot+01fcd39a0d90cdb0e3df
Cc: davem, herbert, linux-crypto, linux-kernel, syzkaller-bugs, xiaopei01
#syz test
---
lib/crypto/x86/poly1305.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/crypto/x86/poly1305.h b/lib/crypto/x86/poly1305.h
index ee92e3740a78..3b9f1024a18d 100644
--- a/lib/crypto/x86/poly1305.h
+++ b/lib/crypto/x86/poly1305.h
@@ -8,6 +8,7 @@
#include <linux/jump_label.h>
#include <linux/kernel.h>
#include <linux/sizes.h>
+#include <linux/string.h>
struct poly1305_arch_internal {
union {
@@ -86,6 +87,7 @@ static __ro_after_init DEFINE_STATIC_KEY_FALSE(poly1305_use_avx512);
static void poly1305_block_init(struct poly1305_block_state *state,
const u8 raw_key[POLY1305_BLOCK_SIZE])
{
+ memset(state, 0, sizeof(struct poly1305_block_state));
poly1305_init_x86_64(state, raw_key);
}
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] [patch] syz test
2025-10-20 21:07 [syzbot] [crypto?] KMSAN: uninit-value in poly1305_blocks syzbot
@ 2025-10-21 1:54 ` Pei Xiao
0 siblings, 0 replies; 4+ messages in thread
From: Pei Xiao @ 2025-10-21 1:54 UTC (permalink / raw)
To: syzbot+01fcd39a0d90cdb0e3df
Cc: davem, herbert, linux-crypto, linux-kernel, syzkaller-bugs, Pei Xiao
#syz test
---
include/crypto/internal/poly1305.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/crypto/internal/poly1305.h b/include/crypto/internal/poly1305.h
index a72fff409ab8..f6de53965319 100644
--- a/include/crypto/internal/poly1305.h
+++ b/include/crypto/internal/poly1305.h
@@ -8,6 +8,7 @@
#include <crypto/poly1305.h>
#include <linux/types.h>
+#include <linux/string.h>
/*
* Poly1305 core functions. These only accept whole blocks; the caller must
@@ -21,7 +22,8 @@ void poly1305_core_setkey(struct poly1305_core_key *key,
const u8 raw_key[POLY1305_BLOCK_SIZE]);
static inline void poly1305_core_init(struct poly1305_state *state)
{
- *state = (struct poly1305_state){};
+ //*state = (struct poly1305_state){};
+ memset(state, 0, sizeof(struct poly1305_state));
}
void poly1305_core_blocks(struct poly1305_state *state,
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-21 5:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <6fnt99vd47a5-6fo0chqsqcpq@nsmail8.2--kylin--1>
2025-10-21 5:25 ` [PATCH] [patch] syz test Herbert Xu
2025-10-21 2:51 [syzbot] [crypto?] KMSAN: uninit-value in poly1305_blocks syzbot
2025-10-21 3:08 ` [PATCH] [patch] syz test Pei Xiao
2025-10-21 3:12 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2025-10-20 21:07 [syzbot] [crypto?] KMSAN: uninit-value in poly1305_blocks syzbot
2025-10-21 1:54 ` [PATCH] [patch] syz test Pei Xiao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®