mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-renesas-soc@vger.kernel.org,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] reset: always include RESET_GPIO driver if possible
Date: Thu, 23 Oct 2025 11:22:49 +0200	[thread overview]
Message-ID: <aPnz6U-fcodRoobU@shikoro> (raw)
In-Reply-To: <5c9761d5a6a14d4c250df6cc4201bca72d963133.camel@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 1571 bytes --]

Hi Philipp,

> > > I dunno for how many drivers this is really applicable, but I really
> > > liked the cleanup of the pca954x driver.
> 
> That cleanup might have been a little premature, given that the reset-
> gpio driver currently only works on OF-based platforms, and even there
> only with gpio controllers with #gpio-cells = <2>.

I see. That kind of spoils my assumption that it is a fallback supported
by the core. Darn, I would still like to have it, but it seems more
complicated than I have time for it :(

> How about selecting RESET_GPIO from I2C_MUX_PCA954x? It already depends
> on GPIOLIB. Although I don't like the idea of drivers being converted
> en masse, all selecting RESET_GPIO ...

Well, on top of that, reset is optional with this driver, so selecting
it doesn't feel proper.

> To be honest, I don't like either very much.
> 
> Yes, the reset-gpio driver is only about three pages in size, but
> force-enabling it for nearly everyone, just because some hardware
> designs like to share resets a little too much, feels wrong to me,
> especially in its current state.

I understand the argument of 'too limited in the current state'. I don't
get the 'share too much' argument? The fallback would remove open-coded
"reset-gpios" handling and sync it with generic reset handling?

> And just default-enabling it doesn't solve the regression problem when
> updating preexisting configs.

Yes.

Well, at least patch 1 seems okay, so users at least get notified of the
problem...

All the best,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-10-23  9:22 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15 20:59 [PATCH v2 0/2] reset: handle RESET_GPIO better to provide the fallback Wolfram Sang
2025-10-15 20:59 ` [PATCH v2 1/2] reset: always bail out on missing RESET_GPIO driver Wolfram Sang
2025-10-17  9:35   ` Philipp Zabel
2025-10-30 11:59   ` Philipp Zabel
2025-10-30 12:54   ` Philipp Zabel
2025-11-03 14:53     ` Krzysztof Kozlowski
2025-11-03 15:12       ` Wolfram Sang
2025-11-03 15:13         ` Krzysztof Kozlowski
2025-11-03 17:10   ` Wolfram Sang
2025-10-15 20:59 ` [PATCH v2 2/2] reset: always include RESET_GPIO driver if possible Wolfram Sang
2025-10-16 13:02   ` Geert Uytterhoeven
2025-10-16 14:27     ` Wolfram Sang
2025-10-17 10:16       ` Bartosz Golaszewski
2025-10-17 10:48         ` Wolfram Sang
2025-10-17 11:09           ` Bartosz Golaszewski
2025-10-17 11:25             ` Wolfram Sang
2025-10-17 17:02               ` Bartosz Golaszewski
2025-10-22  9:07                 ` Philipp Zabel
2025-10-23  9:22                   ` Wolfram Sang [this message]
2025-10-23  9:37                     ` Bartosz Golaszewski
2025-10-23 11:18                       ` Wolfram Sang
2025-10-23 12:04                         ` Bartosz Golaszewski
2025-10-23 12:51                           ` Wolfram Sang
2025-10-17  9:42     ` Philipp Zabel
2025-10-17  9:46       ` Wolfram Sang
2025-10-17  9:35   ` Philipp Zabel
2025-10-17  9:43     ` Wolfram Sang
2025-10-16  0:02 ` [PATCH v2 0/2] reset: handle RESET_GPIO better to provide the fallback Kuninori Morimoto
2025-11-03 15:08   ` Krzysztof Kozlowski
2025-11-03 15:25     ` Wolfram Sang
2025-11-03 15:26       ` Krzysztof Kozlowski
2025-11-03 15:12 ` Krzysztof Kozlowski
2025-11-03 15:23   ` Wolfram Sang
2025-11-03 15:26     ` Krzysztof Kozlowski
2025-11-03 15:52       ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPnz6U-fcodRoobU@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=brgl@bgdev.pl \
    --cc=geert@linux-m68k.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®