mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Koichiro Den <den@valinux.co.jp>
Cc: ntb@lists.linux.dev, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, jdmason@kudzu.us,
	dave.jiang@intel.com, allenbh@gmail.com, mani@kernel.org,
	kwilczynski@kernel.org, kishon@kernel.org, bhelgaas@google.com,
	jbrunet@baylibre.com, lpieralisi@kernel.org, yebin10@huawei.com,
	geert+renesas@glider.be, arnd@arndb.de
Subject: Re: [PATCH 2/6] PCI: endpoint: Fix parameter order for .drop_link
Date: Fri, 24 Oct 2025 11:48:48 -0400	[thread overview]
Message-ID: <aPuf4KyzR/h85eUs@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20251023071757.901181-3-den@valinux.co.jp>

On Thu, Oct 23, 2025 at 04:17:53PM +0900, Koichiro Den wrote:
> The unlink callbacks passed the parameters in the wrong order that led
> to looking up the wrong group objects. Swap the arguments so that the
> first parameter is the epf item and the second is the epc item.
>
> Cc: <stable@vger.kernel.org>
> Fixes: e85a2d783762 ("PCI: endpoint: Add support in configfs to associate two EPCs with EPF")
> Signed-off-by: Koichiro Den <den@valinux.co.jp>

Nice found.

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
>  drivers/pci/endpoint/pci-ep-cfs.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/endpoint/pci-ep-cfs.c b/drivers/pci/endpoint/pci-ep-cfs.c
> index ef50c82e647f..c7cf6c76d116 100644
> --- a/drivers/pci/endpoint/pci-ep-cfs.c
> +++ b/drivers/pci/endpoint/pci-ep-cfs.c
> @@ -69,8 +69,8 @@ static int pci_secondary_epc_epf_link(struct config_item *epf_item,
>  	return 0;
>  }
>
> -static void pci_secondary_epc_epf_unlink(struct config_item *epc_item,
> -					 struct config_item *epf_item)
> +static void pci_secondary_epc_epf_unlink(struct config_item *epf_item,
> +					 struct config_item *epc_item)
>  {
>  	struct pci_epf_group *epf_group = to_pci_epf_group(epf_item->ci_parent);
>  	struct pci_epc_group *epc_group = to_pci_epc_group(epc_item);
> @@ -133,8 +133,8 @@ static int pci_primary_epc_epf_link(struct config_item *epf_item,
>  	return 0;
>  }
>
> -static void pci_primary_epc_epf_unlink(struct config_item *epc_item,
> -				       struct config_item *epf_item)
> +static void pci_primary_epc_epf_unlink(struct config_item *epf_item,
> +				       struct config_item *epc_item)
>  {
>  	struct pci_epf_group *epf_group = to_pci_epf_group(epf_item->ci_parent);
>  	struct pci_epc_group *epc_group = to_pci_epc_group(epc_item);
> --
> 2.48.1
>

  reply	other threads:[~2025-10-24 15:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-23  7:17 [PATCH 0/6] PCI: endpoint/NTB: Harden vNTB resource management Koichiro Den
2025-10-23  7:17 ` [PATCH 1/6] NTB: epf: Avoid pci_iounmap() with offset when PEER_SPAD and CONFIG share BAR Koichiro Den
2025-10-24 15:45   ` Frank Li
2025-10-24 16:45     ` Koichiro Den
2025-10-23  7:17 ` [PATCH 2/6] PCI: endpoint: Fix parameter order for .drop_link Koichiro Den
2025-10-24 15:48   ` Frank Li [this message]
2025-10-23  7:17 ` [PATCH 3/6] PCI: endpoint: pci-epf-vntb: Remove duplicate resource teardown Koichiro Den
2025-10-24 21:16   ` Frank Li
2025-10-23  7:17 ` [PATCH 4/6] PCI: endpoint: pci-epf-ntb: " Koichiro Den
2025-10-23  7:17 ` [PATCH 5/6] NTB: epf: vntb: Stop cmd_andler work in epf_ntb_epc_cleanup Koichiro Den
2025-10-24 18:44   ` Frank Li
2025-10-27  5:40     ` Koichiro Den
2025-10-23  7:17 ` [PATCH 6/6] PCI: endpoint: pci-epf-vntb: Manage ntb_dev lifetime and fix vpci bus teardown Koichiro Den

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPuf4KyzR/h85eUs@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=allenbh@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=dave.jiang@intel.com \
    --cc=den@valinux.co.jp \
    --cc=geert+renesas@glider.be \
    --cc=jbrunet@baylibre.com \
    --cc=jdmason@kudzu.us \
    --cc=kishon@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=ntb@lists.linux.dev \
    --cc=yebin10@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®