From: Feng Tang <feng.tang@linux.alibaba.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH v2 1/6] panic: sys_info: Capture si_bits_global before iterating over it
Date: Thu, 30 Oct 2025 10:00:15 +0800 [thread overview]
Message-ID: <aQLGr25DrvA62uDH@U-2FWC9VHC-2323.local> (raw)
In-Reply-To: <20251029111202.3217870-3-andriy.shevchenko@linux.intel.com>
On Wed, Oct 29, 2025 at 12:07:36PM +0100, Andy Shevchenko wrote:
> The for-loop might re-read the content of the memory the si_bits_global
> points to on each iteration. Instead, just capture it for the sake of
> consistency and use that instead.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Feng Tang <feng.tang@linux.alibaba.com>
Thanks!
next prev parent reply other threads:[~2025-10-30 2:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 11:07 [PATCH v2 0/6] panic: sys_info: Refactor and fix a potential issue Andy Shevchenko
2025-10-29 11:07 ` [PATCH v2 1/6] panic: sys_info: Capture si_bits_global before iterating over it Andy Shevchenko
2025-10-30 2:00 ` Feng Tang [this message]
2025-10-29 11:07 ` [PATCH v2 2/6] panic: sys_info: Align constant definition names with parameters Andy Shevchenko
2025-10-30 1:59 ` Feng Tang
2025-10-29 11:07 ` [PATCH v2 3/6] panic: sys_info: Replace struct sys_info_name with plain array of strings Andy Shevchenko
2025-10-30 2:01 ` Feng Tang
2025-10-30 7:36 ` Andy Shevchenko
2025-10-30 8:45 ` Feng Tang
2025-10-30 9:05 ` Andy Shevchenko
2025-10-30 10:36 ` Feng Tang
2025-10-29 11:07 ` [PATCH v2 4/6] panic: sys_info: Rewrite a fix for a compilation error (`make W=1`) Andy Shevchenko
2025-10-29 11:07 ` [PATCH v2 5/6] panic: sys_info: Deduplicate local variable 'table; assignments Andy Shevchenko
2025-10-30 2:11 ` Feng Tang
2025-10-29 11:07 ` [PATCH v2 6/6] panic: sys_info: Factor out read and write handlers Andy Shevchenko
2025-10-30 2:06 ` Feng Tang
2025-10-30 7:44 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQLGr25DrvA62uDH@U-2FWC9VHC-2323.local \
--to=feng.tang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®