* [PATCH] MIPS: Fix whitespace damage in r4k_wait from VS timer fix
@ 2025-10-19 11:49 Maciej W. Rozycki
2025-12-01 6:50 ` [PING][PATCH] " Maciej W. Rozycki
2025-12-01 9:40 ` [PATCH] " Thomas Bogendoerfer
0 siblings, 2 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2025-10-19 11:49 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Marco Crivellari, Frederic Weisbecker, linux-mips, linux-kernel
Remove stray spaces/tabs introduced with commit 56651128e2fb ("MIPS: Fix
idle VS timer enqueue") and add missing indentation for a branch delay
slot.
Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
---
It would have been caught, for the most issues, with:
whitespace = indent-with-non-tab,space-before-tab,trailing-space
in git configuration. Is there a way to get it propagated with checkouts?
---
arch/mips/kernel/genex.S | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
linux-mips-idle-vs-timer-format.diff
Index: linux-macro/arch/mips/kernel/genex.S
===================================================================
--- linux-macro.orig/arch/mips/kernel/genex.S
+++ linux-macro/arch/mips/kernel/genex.S
@@ -109,7 +109,7 @@ NESTED(except_vec3_r4000, 0, sp)
.align 5
LEAF(r4k_wait)
/* Keep the ISA bit clear for calculations on local labels here. */
-0: .fill 0
+0: .fill 0
/* Start of idle interrupt region. */
local_irq_enable
/*
@@ -121,7 +121,7 @@ LEAF(r4k_wait)
*/
1: .fill 0
/* The R2 EI/EHB sequence takes 8 bytes, otherwise pad up. */
- .if 1b - 0b > 32
+ .if 1b - 0b > 32
.error "overlong idle interrupt region"
.elseif 1b - 0b > 8
.align 4
@@ -146,10 +146,10 @@ LEAF(r4k_wait)
MFC0 k0, CP0_EPC
/* Subtract/add 2 to let the ISA bit propagate through the mask. */
PTR_LA k1, r4k_wait_insn - 2
- ori k0, r4k_wait_idle_size - 2
+ ori k0, r4k_wait_idle_size - 2
.set noreorder
bne k0, k1, \handler
- PTR_ADDIU k0, r4k_wait_exit - r4k_wait_insn + 2
+ PTR_ADDIU k0, r4k_wait_exit - r4k_wait_insn + 2
.set reorder
MTC0 k0, CP0_EPC
.set pop
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PING][PATCH] MIPS: Fix whitespace damage in r4k_wait from VS timer fix
2025-10-19 11:49 [PATCH] MIPS: Fix whitespace damage in r4k_wait from VS timer fix Maciej W. Rozycki
@ 2025-12-01 6:50 ` Maciej W. Rozycki
2025-12-01 9:40 ` [PATCH] " Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2025-12-01 6:50 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Marco Crivellari, Frederic Weisbecker, linux-mips, linux-kernel
On Sun, 19 Oct 2025, Maciej W. Rozycki wrote:
> Remove stray spaces/tabs introduced with commit 56651128e2fb ("MIPS: Fix
> idle VS timer enqueue") and add missing indentation for a branch delay
> slot.
Ping for:
<https://lore.kernel.org/r/alpine.DEB.2.21.2510191229030.39634@angie.orcam.me.uk/>.
Maciej
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: Fix whitespace damage in r4k_wait from VS timer fix
2025-10-19 11:49 [PATCH] MIPS: Fix whitespace damage in r4k_wait from VS timer fix Maciej W. Rozycki
2025-12-01 6:50 ` [PING][PATCH] " Maciej W. Rozycki
@ 2025-12-01 9:40 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2025-12-01 9:40 UTC (permalink / raw)
To: Maciej W. Rozycki
Cc: Marco Crivellari, Frederic Weisbecker, linux-mips, linux-kernel
On Sun, Oct 19, 2025 at 12:49:02PM +0100, Maciej W. Rozycki wrote:
> Remove stray spaces/tabs introduced with commit 56651128e2fb ("MIPS: Fix
> idle VS timer enqueue") and add missing indentation for a branch delay
> slot.
>
> Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
> ---
> It would have been caught, for the most issues, with:
>
> whitespace = indent-with-non-tab,space-before-tab,trailing-space
>
> in git configuration. Is there a way to get it propagated with checkouts?
> ---
> arch/mips/kernel/genex.S | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-01 9:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-19 11:49 [PATCH] MIPS: Fix whitespace damage in r4k_wait from VS timer fix Maciej W. Rozycki
2025-12-01 6:50 ` [PING][PATCH] " Maciej W. Rozycki
2025-12-01 9:40 ` [PATCH] " Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®