* [PATCH next] platform/x86: asus-armoury: Fix error code in mini_led_mode_current_value_store()
@ 2025-11-21 13:33 Dan Carpenter
2025-11-21 17:00 ` Ilpo Järvinen
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-11-21 13:33 UTC (permalink / raw)
To: Luke D. Jones
Cc: Corentin Chary, Denis Benato, Hans de Goede, Ilpo Järvinen,
platform-driver-x86, linux-kernel, kernel-janitors
There are two return statements in a row here. The first one is wrong
so delete that one. This changes the return value to -ENODEV.
Fixes: f99eb098090e ("platform/x86: asus-armoury: move existing tunings to asus-armoury module")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/platform/x86/asus-armoury.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
index 9f67218ecd14..a2cfaaa71f25 100644
--- a/drivers/platform/x86/asus-armoury.c
+++ b/drivers/platform/x86/asus-armoury.c
@@ -463,7 +463,7 @@ static ssize_t mini_led_mode_current_value_store(struct kobject *kobj,
}
if (mode >= mini_led_mode_map_size) {
- return pr_warn("mini-LED mode unrecognized device: %u\n", mode);
+ pr_warn("mini-LED mode unrecognized device: %u\n", mode);
return -ENODEV;
}
--
2.51.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH next] platform/x86: asus-armoury: Fix error code in mini_led_mode_current_value_store()
2025-11-21 13:33 [PATCH next] platform/x86: asus-armoury: Fix error code in mini_led_mode_current_value_store() Dan Carpenter
@ 2025-11-21 17:00 ` Ilpo Järvinen
0 siblings, 0 replies; 2+ messages in thread
From: Ilpo Järvinen @ 2025-11-21 17:00 UTC (permalink / raw)
To: Luke D. Jones, Dan Carpenter
Cc: Corentin Chary, Denis Benato, Hans de Goede, platform-driver-x86,
linux-kernel, kernel-janitors
On Fri, 21 Nov 2025 16:33:56 +0300, Dan Carpenter wrote:
> There are two return statements in a row here. The first one is wrong
> so delete that one. This changes the return value to -ENODEV.
>
>
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: asus-armoury: Fix error code in mini_led_mode_current_value_store()
commit: 0a69fe8f097f7410dc232259129d334518d4e8dc
--
i.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-21 17:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-21 13:33 [PATCH next] platform/x86: asus-armoury: Fix error code in mini_led_mode_current_value_store() Dan Carpenter
2025-11-21 17:00 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®