mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH]  fix kmalloc bug in bpf_prog_alloc_no_stats
@ 2025-11-24 18:05 Hithashree Bojanala
  2025-11-24 18:33 ` Matthew Wilcox
  0 siblings, 1 reply; 2+ messages in thread
From: Hithashree Bojanala @ 2025-11-24 18:05 UTC (permalink / raw)
  Cc: linux-kernel, linux-doc, Hithashri Bojanala

From: Hithashri Bojanala <bojanalahithashri@gmail.com>

fix https://syzkaller.appspot.com/bug?extid=d4264133b3e51212ea30
vmalloc doesnt support __GFP_ACCOUNT
---
 kernel/bpf/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c
index d595fe512498..ffe2658ce165 100644
--- a/kernel/bpf/core.c
+++ b/kernel/bpf/core.c
@@ -263,7 +263,8 @@ struct bpf_prog *bpf_prog_realloc(struct bpf_prog *fp_old, unsigned int size,
 	if (pages <= fp_old->pages)
 		return fp_old;
 
-	fp = __vmalloc(size, gfp_flags);
+	/*vmalloc doesn't support __GFP_ACCOUNT, so strip it for the vmalloc call */
+	fp = __vmalloc(size, gfp_flags & ~__GFP_ACCOUNT);
 	if (fp) {
 		memcpy(fp, fp_old, fp_old->pages * PAGE_SIZE);
 		fp->pages = pages;
-- 
2.47.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH]  fix kmalloc bug in bpf_prog_alloc_no_stats
  2025-11-24 18:05 [PATCH] fix kmalloc bug in bpf_prog_alloc_no_stats Hithashree Bojanala
@ 2025-11-24 18:33 ` Matthew Wilcox
  0 siblings, 0 replies; 2+ messages in thread
From: Matthew Wilcox @ 2025-11-24 18:33 UTC (permalink / raw)
  To: Hithashree Bojanala; +Cc: linux-kernel, linux-doc

On Mon, Nov 24, 2025 at 01:05:20PM -0500, Hithashree Bojanala wrote:
> From: Hithashri Bojanala <bojanalahithashri@gmail.com>
> 
> fix https://syzkaller.appspot.com/bug?extid=d4264133b3e51212ea30
> vmalloc doesnt support __GFP_ACCOUNT

NAK.
https://lore.kernel.org/linux-mm/20251117173530.43293-1-vishal.moola@gmail.com/
fixed this.  Discussion here:
https://lore.kernel.org/linux-mm/aRXeK_C44xGb3ovg@milan/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-24 18:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-24 18:05 [PATCH] fix kmalloc bug in bpf_prog_alloc_no_stats Hithashree Bojanala
2025-11-24 18:33 ` Matthew Wilcox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®