mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Guido Günther" <agx@sigxcpu.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	Svyatoslav Ryhel <clamor95@gmail.com>,
	David Heidelberg <david@ixit.cz>,
	Linus Walleij <linus.walleij@linaro.org>,
	Kaustabh Chakraborty <kauschluss@disroot.org>,
	Maxim Schwalm <maxim.schwalm@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Colin Ian King <colin.i.king@gmail.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panel: visionox-rm69299: add backlight dependency
Date: Thu, 4 Dec 2025 11:23:02 +0100	[thread overview]
Message-ID: <aTFhBtzzKbN3mjqw@quark2.heme.sigxcpu.org> (raw)
In-Reply-To: <20251204094734.1031114-1-arnd@kernel.org>

Hi,
On Thu, Dec 04, 2025 at 10:47:26AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The recently added backlight support breaks when CONFIG_BACKLIGHT_CLASS_DEVICE
> is turned off:
> 
> arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-visionox-rm69299.o: in function `visionox_rm69299_probe':
> panel-visionox-rm69299.c:(.text.visionox_rm69299_probe+0x92): undefined reference to `devm_backlight_device_register'
> arm-linux-gnueabi-ld: (devm_backlight_device_register): Unknown destination type (ARM/Thumb) in drivers/gpu/drm/panel/panel-visionox-rm69299.o
> 
> Add the appropriate Kconfig dependency.
> 
> Fixes: 7911d8cab554 ("drm/panel: visionox-rm69299: Add backlight support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks for looking at this. This is a duplicate of

  https://lore.kernel.org/phone-devel/20251017-visionox-rm69299-bl-v2-1-9dfa06606754@sigxcpu.org/

though, idk why it didn't get applied.

Cheers,
 -- Guido

> ---
>  drivers/gpu/drm/panel/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 76f6af819037..2923148dcf07 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -1163,6 +1163,7 @@ config DRM_PANEL_VISIONOX_R66451
>  
>  config DRM_PANEL_VISIONOX_RM69299
>  	tristate "Visionox RM69299"
> +	depends on BACKLIGHT_CLASS_DEVICE
>  	depends on OF
>  	depends on DRM_MIPI_DSI
>  	help
> -- 
> 2.39.5
> 

      reply	other threads:[~2025-12-04 10:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04  9:47 Arnd Bergmann
2025-12-04 10:23 ` Guido Günther [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTFhBtzzKbN3mjqw@quark2.heme.sigxcpu.org \
    --to=agx@sigxcpu.org \
    --cc=airlied@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=clamor95@gmail.com \
    --cc=colin.i.king@gmail.com \
    --cc=david@ixit.cz \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=kauschluss@disroot.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maxim.schwalm@gmail.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®