* [PATCH] usb: chipidea: ci_hdrc_imx: use "wakeup" suffix for wakeup interrupt name
@ 2026-01-08 10:35 Xu Yang
2026-01-08 15:45 ` Frank Li
0 siblings, 1 reply; 3+ messages in thread
From: Xu Yang @ 2026-01-08 10:35 UTC (permalink / raw)
To: peter.chen, gregkh, shawnguo, s.hauer, kernel, festevam
Cc: linux-usb, imx, linux-arm-kernel, linux-kernel, jun.li
Currently the wakeup and controller interrupt name are same. It's not
easy to find the correct one in /proc/interrupt at the first glance.
Rename the wakeup interrupt name for better distinction.
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
drivers/usb/chipidea/ci_hdrc_imx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
index d4ee9e16332f..e4345e0eea59 100644
--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -385,6 +385,7 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
const struct ci_hdrc_imx_platform_flag *imx_platform_flag;
struct device_node *np = pdev->dev.of_node;
struct device *dev = &pdev->dev;
+ const char *irq_name;
imx_platform_flag = of_device_get_match_data(&pdev->dev);
@@ -525,10 +526,11 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
data->wakeup_irq = platform_get_irq_optional(pdev, 1);
if (data->wakeup_irq > 0) {
+ irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s:wakeup", pdata.name);
ret = devm_request_threaded_irq(dev, data->wakeup_irq,
NULL, ci_wakeup_irq_handler,
IRQF_ONESHOT | IRQF_NO_AUTOEN,
- pdata.name, data);
+ irq_name, data);
if (ret)
goto err_clk;
}
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: chipidea: ci_hdrc_imx: use "wakeup" suffix for wakeup interrupt name
2026-01-08 10:35 [PATCH] usb: chipidea: ci_hdrc_imx: use "wakeup" suffix for wakeup interrupt name Xu Yang
@ 2026-01-08 15:45 ` Frank Li
2026-01-12 10:11 ` Xu Yang
0 siblings, 1 reply; 3+ messages in thread
From: Frank Li @ 2026-01-08 15:45 UTC (permalink / raw)
To: Xu Yang
Cc: peter.chen, gregkh, shawnguo, s.hauer, kernel, festevam,
linux-usb, imx, linux-arm-kernel, linux-kernel, jun.li
On Thu, Jan 08, 2026 at 06:35:21PM +0800, Xu Yang wrote:
> Currently the wakeup and controller interrupt name are same. It's not
> easy to find the correct one in /proc/interrupt at the first glance.
> Rename the wakeup interrupt name for better distinction.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
> drivers/usb/chipidea/ci_hdrc_imx.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index d4ee9e16332f..e4345e0eea59 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -385,6 +385,7 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
> const struct ci_hdrc_imx_platform_flag *imx_platform_flag;
> struct device_node *np = pdev->dev.of_node;
> struct device *dev = &pdev->dev;
> + const char *irq_name;
>
> imx_platform_flag = of_device_get_match_data(&pdev->dev);
>
> @@ -525,10 +526,11 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
>
> data->wakeup_irq = platform_get_irq_optional(pdev, 1);
> if (data->wakeup_irq > 0) {
> + irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s:wakeup", pdata.name);
Need check irq_name
Frank
> ret = devm_request_threaded_irq(dev, data->wakeup_irq,
> NULL, ci_wakeup_irq_handler,
> IRQF_ONESHOT | IRQF_NO_AUTOEN,
> - pdata.name, data);
> + irq_name, data);
> if (ret)
> goto err_clk;
> }
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: chipidea: ci_hdrc_imx: use "wakeup" suffix for wakeup interrupt name
2026-01-08 15:45 ` Frank Li
@ 2026-01-12 10:11 ` Xu Yang
0 siblings, 0 replies; 3+ messages in thread
From: Xu Yang @ 2026-01-12 10:11 UTC (permalink / raw)
To: Frank Li
Cc: peter.chen, gregkh, shawnguo, s.hauer, kernel, festevam,
linux-usb, imx, linux-arm-kernel, linux-kernel, jun.li
On Thu, Jan 08, 2026 at 10:45:48AM -0500, Frank Li wrote:
> On Thu, Jan 08, 2026 at 06:35:21PM +0800, Xu Yang wrote:
> > Currently the wakeup and controller interrupt name are same. It's not
> > easy to find the correct one in /proc/interrupt at the first glance.
> > Rename the wakeup interrupt name for better distinction.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > ---
> > drivers/usb/chipidea/ci_hdrc_imx.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> > index d4ee9e16332f..e4345e0eea59 100644
> > --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> > +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> > @@ -385,6 +385,7 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
> > const struct ci_hdrc_imx_platform_flag *imx_platform_flag;
> > struct device_node *np = pdev->dev.of_node;
> > struct device *dev = &pdev->dev;
> > + const char *irq_name;
> >
> > imx_platform_flag = of_device_get_match_data(&pdev->dev);
> >
> > @@ -525,10 +526,11 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
> >
> > data->wakeup_irq = platform_get_irq_optional(pdev, 1);
> > if (data->wakeup_irq > 0) {
> > + irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s:wakeup", pdata.name);
>
> Need check irq_name
OK, will do.
Thanks,
Xu Yang
>
> Frank
>
> > ret = devm_request_threaded_irq(dev, data->wakeup_irq,
> > NULL, ci_wakeup_irq_handler,
> > IRQF_ONESHOT | IRQF_NO_AUTOEN,
> > - pdata.name, data);
> > + irq_name, data);
> > if (ret)
> > goto err_clk;
> > }
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-12 10:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-08 10:35 [PATCH] usb: chipidea: ci_hdrc_imx: use "wakeup" suffix for wakeup interrupt name Xu Yang
2026-01-08 15:45 ` Frank Li
2026-01-12 10:11 ` Xu Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®