mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] resource: provide 0args DEFINE_RES variant for unset resource desc
@ 2025-12-13 11:53 Christian Marangi
  2025-12-28 18:14 ` Andy Shevchenko
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Marangi @ 2025-12-13 11:53 UTC (permalink / raw)
  To: Christian Marangi, Andrew Morton, Bjorn Helgaas, Andy Shevchenko,
	linux-kernel
  Cc: Ilpo Järvinen

Provide a variant of DEFINE_RES that takes 0 arguments to initialize an
"unset" resource descriptor.

This should be used for the improper case of

	struct resource res = {};

where DEFINE_RES() should be used.

With this new helper variant, it would result in:

	struct resource res = DEFINE_RES();

instead of having to define the full 3 arguments:

	struct resource res = DEFINE_RES(0, 0, IORESOURCE_UNSET);

DEFINE_RES() with no args, will set the flags to IORESOURCE_UNSET
signaling the resource descriptor is UNSET and doesn't reflect an actual
resource currently.

Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
Changes v2:
- Add missing header
- Make one line
- Add review tag

 include/linux/ioport.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/include/linux/ioport.h b/include/linux/ioport.h
index d3e837eb8760..5779187f8698 100644
--- a/include/linux/ioport.h
+++ b/include/linux/ioport.h
@@ -10,6 +10,7 @@
 #define _LINUX_IOPORT_H
 
 #ifndef __ASSEMBLY__
+#include <linux/args.h>
 #include <linux/bits.h>
 #include <linux/compiler.h>
 #include <linux/minmax.h>
@@ -168,8 +169,12 @@ enum {
 
 #define DEFINE_RES_NAMED(_start, _size, _name, _flags)			\
 	DEFINE_RES_NAMED_DESC(_start, _size, _name, _flags, IORES_DESC_NONE)
-#define DEFINE_RES(_start, _size, _flags)				\
+#define __DEFINE_RES0()							\
+	DEFINE_RES_NAMED(0, 0, NULL, IORESOURCE_UNSET)
+#define __DEFINE_RES3(_start, _size, _flags)				\
 	DEFINE_RES_NAMED(_start, _size, NULL, _flags)
+#define DEFINE_RES(...)							\
+	CONCATENATE(__DEFINE_RES, COUNT_ARGS(__VA_ARGS__))(__VA_ARGS__)
 
 #define DEFINE_RES_IO_NAMED(_start, _size, _name)			\
 	DEFINE_RES_NAMED((_start), (_size), (_name), IORESOURCE_IO)
-- 
2.51.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] resource: provide 0args DEFINE_RES variant for unset resource desc
  2025-12-13 11:53 [PATCH v2] resource: provide 0args DEFINE_RES variant for unset resource desc Christian Marangi
@ 2025-12-28 18:14 ` Andy Shevchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2025-12-28 18:14 UTC (permalink / raw)
  To: Christian Marangi
  Cc: Andrew Morton, Bjorn Helgaas, linux-kernel, Ilpo Järvinen

On Sat, Dec 13, 2025 at 12:53:09PM +0100, Christian Marangi wrote:
> Provide a variant of DEFINE_RES that takes 0 arguments to initialize an
> "unset" resource descriptor.
> 
> This should be used for the improper case of
> 
> 	struct resource res = {};
> 
> where DEFINE_RES() should be used.
> 
> With this new helper variant, it would result in:
> 
> 	struct resource res = DEFINE_RES();
> 
> instead of having to define the full 3 arguments:
> 
> 	struct resource res = DEFINE_RES(0, 0, IORESOURCE_UNSET);
> 
> DEFINE_RES() with no args, will set the flags to IORESOURCE_UNSET
> signaling the resource descriptor is UNSET and doesn't reflect an actual
> resource currently.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-28 18:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-13 11:53 [PATCH v2] resource: provide 0args DEFINE_RES variant for unset resource desc Christian Marangi
2025-12-28 18:14 ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®