mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Alex Elder <elder@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] greybus: Use bus methods for .probe() and .remove()
Date: Tue, 13 Jan 2026 11:06:43 +0100	[thread overview]
Message-ID: <aWYZM-c1XcvD6LPw@hovoldconsulting.com> (raw)
In-Reply-To: <20251210175943.590059-2-u.kleine-koenig@baylibre.com>

On Wed, Dec 10, 2025 at 06:59:39PM +0100, Uwe Kleine-König wrote:
> These are nearly identical to the respective driver callbacks. The only
> difference is that .remove() returns void instead of int.
> 
> The objective is to get rid of users of struct device_driver callbacks
> .probe() and .remove() to eventually remove these.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
 
> -const struct bus_type greybus_bus_type = {
> -	.name =		"greybus",
> -	.match =	greybus_match_device,
> -	.uevent =	greybus_uevent,
> -	.shutdown =	greybus_shutdown,
> -};
> -
 
> +const struct bus_type greybus_bus_type = {
> +	.name = "greybus",
> +	.match = greybus_match_device,
> +	.uevent = greybus_uevent,
> +	.probe = greybus_probe,
> +	.remove = greybus_remove,
> +	.shutdown = greybus_shutdown,
> +};
> +

Please keep the indentation style when moving the struct.

With that addressed:

Acked-by: Johan Hovold <johan@kernel.org>

Johan

      parent reply	other threads:[~2026-01-13 10:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-10 17:59 Uwe Kleine-König
2026-01-12 11:58 ` Uwe Kleine-König
2026-01-12 12:06   ` Greg Kroah-Hartman
2026-01-12 12:27     ` Uwe Kleine-König
2026-01-13 10:06 ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWYZM-c1XcvD6LPw@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®