mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sahil Chandna <chandna.sahil@gmail.com>
To: syzbot <syzbot+bcfb99c4698edf7a1f52@syzkaller.appspotmail.com>
Cc: jack@suse.com, linux-kernel@vger.kernel.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [udf?] WARNING: bad unlock balance in __wait_on_freeing_inode
Date: Thu, 22 Jan 2026 22:27:14 +0530	[thread overview]
Message-ID: <aXJW6jWKqi0bfagi@chandna.localdomain> (raw)
In-Reply-To: <69717cbf.050a0220.706b.001d.GAE@google.com>

#syz test
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -2521,14 +2521,18 @@ static void __wait_on_freeing_inode(struct inode *inode, bool is_inode_hash_lock
  	wq_head = inode_bit_waitqueue(&wqe, inode, __I_NEW);
  	prepare_to_wait_event(wq_head, &wqe.wq_entry, TASK_UNINTERRUPTIBLE);
  	spin_unlock(&inode->i_lock);
-	rcu_read_unlock();
+	if (rcu_read_lock_any_held())
+		rcu_read_unlock();
+
  	if (is_inode_hash_locked)
  		spin_unlock(&inode_hash_lock);
  	schedule();
  	finish_wait(wq_head, &wqe.wq_entry);
  	if (is_inode_hash_locked)
  		spin_lock(&inode_hash_lock);
-	rcu_read_lock();
+
+	if (rcu_read_lock_any_held())
+		rcu_read_lock();
  }
  
  static __initdata unsigned long ihash_entries;
-- 



  parent reply	other threads:[~2026-01-22 16:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22  1:26 syzbot
2026-01-22  2:16 ` Edward Adam Davis
2026-01-22  2:30   ` syzbot
2026-01-22 16:42 ` Sahil Chandna
2026-01-22 16:44   ` syzbot
2026-01-22 16:57 ` Sahil Chandna [this message]
2026-01-22 16:59   ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXJW6jWKqi0bfagi@chandna.localdomain \
    --to=chandna.sahil@gmail.com \
    --cc=jack@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+bcfb99c4698edf7a1f52@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®