mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: [PATCH net-next 1/2] net: ti: icssg-prueth-sr1: Remove unused workqueue
       [not found] ` <20260204-icssg-prueth-workqueue-v1-1-9a892f4b293d@gmail.com>
@ 2026-02-04 10:38   ` Markus Elfring
  2026-02-04 12:08     ` Kevin Hao
  0 siblings, 1 reply; 4+ messages in thread
From: Markus Elfring @ 2026-02-04 10:38 UTC (permalink / raw)
  To: Kevin Hao, netdev
  Cc: LKML, Andrew Lunn, Byungchul Park, David S. Miller, Eric Dumazet,
	Himanshu Mittal, Jacob Keller, MD Danish Anwar, Jakub Kicinski,
	Meghana Malladi, Paolo Abeni, Roger Quadros, Simon Horman,
	Vadim Fedorenko

> The dedicated workqueue emac->cmd_wq is not utilized in this driver and
> can be safely removed.

Wording suggestion:
Remove the work queue “emac->cmd_wq” because it is not utilized in this driver.

Regards,
Markus

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next 2/2] net: ti: icssg-prueth: Use system default workqueue in ndo_set_rx_mode callback
       [not found] ` <20260204-icssg-prueth-workqueue-v1-2-9a892f4b293d@gmail.com>
@ 2026-02-04 10:45   ` Markus Elfring
  2026-02-04 12:10     ` Kevin Hao
  0 siblings, 1 reply; 4+ messages in thread
From: Markus Elfring @ 2026-02-04 10:45 UTC (permalink / raw)
  To: Kevin Hao, netdev
  Cc: LKML, Andrew Lunn, Byungchul Park, David S. Miller, Eric Dumazet,
	Himanshu Mittal, Jacob Keller, MD Danish Anwar, Jakub Kicinski,
	Meghana Malladi, Paolo Abeni, Roger Quadros, Simon Horman,
	Vadim Fedorenko

> Currently, the actual processing of ndo_set_rx_mode is executed in a work.

                                                                            queue?


> However, there is no need to create a dedicated workqueue for …


Regards,
Markus

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next 1/2] net: ti: icssg-prueth-sr1: Remove unused workqueue
  2026-02-04 10:38   ` [PATCH net-next 1/2] net: ti: icssg-prueth-sr1: Remove unused workqueue Markus Elfring
@ 2026-02-04 12:08     ` Kevin Hao
  0 siblings, 0 replies; 4+ messages in thread
From: Kevin Hao @ 2026-02-04 12:08 UTC (permalink / raw)
  To: Markus Elfring
  Cc: netdev, LKML, Andrew Lunn, Byungchul Park, David S. Miller,
	Eric Dumazet, Himanshu Mittal, Jacob Keller, MD Danish Anwar,
	Jakub Kicinski, Meghana Malladi, Paolo Abeni, Roger Quadros,
	Simon Horman, Vadim Fedorenko

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

On Wed, Feb 04, 2026 at 11:38:37AM +0100, Markus Elfring wrote:
> > The dedicated workqueue emac->cmd_wq is not utilized in this driver and
> > can be safely removed.
> 
> Wording suggestion:
> Remove the work queue “emac->cmd_wq” because it is not utilized in this driver.

Will update.

Thanks,
Kevin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next 2/2] net: ti: icssg-prueth: Use system default workqueue in ndo_set_rx_mode callback
  2026-02-04 10:45   ` [PATCH net-next 2/2] net: ti: icssg-prueth: Use system default workqueue in ndo_set_rx_mode callback Markus Elfring
@ 2026-02-04 12:10     ` Kevin Hao
  0 siblings, 0 replies; 4+ messages in thread
From: Kevin Hao @ 2026-02-04 12:10 UTC (permalink / raw)
  To: Markus Elfring
  Cc: netdev, LKML, Andrew Lunn, Byungchul Park, David S. Miller,
	Eric Dumazet, Himanshu Mittal, Jacob Keller, MD Danish Anwar,
	Jakub Kicinski, Meghana Malladi, Paolo Abeni, Roger Quadros,
	Simon Horman, Vadim Fedorenko

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

On Wed, Feb 04, 2026 at 11:45:24AM +0100, Markus Elfring wrote:
> > Currently, the actual processing of ndo_set_rx_mode is executed in a work.
> 
>                                                                             queue?

Will change to workqueue.

Thanks,
Kevin

> 
> 
> > However, there is no need to create a dedicated workqueue for …
> 
> 
> Regards,
> Markus

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-02-04 12:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20260204-icssg-prueth-workqueue-v1-0-9a892f4b293d@gmail.com>
     [not found] ` <20260204-icssg-prueth-workqueue-v1-1-9a892f4b293d@gmail.com>
2026-02-04 10:38   ` [PATCH net-next 1/2] net: ti: icssg-prueth-sr1: Remove unused workqueue Markus Elfring
2026-02-04 12:08     ` Kevin Hao
     [not found] ` <20260204-icssg-prueth-workqueue-v1-2-9a892f4b293d@gmail.com>
2026-02-04 10:45   ` [PATCH net-next 2/2] net: ti: icssg-prueth: Use system default workqueue in ndo_set_rx_mode callback Markus Elfring
2026-02-04 12:10     ` Kevin Hao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®