* [PATCH] perf/x86/amd/ibs: Fix comment typo in ibs_op_data
@ 2026-01-13 12:50 rrrrr4413
2026-01-13 13:45 ` Borislav Petkov
2026-01-13 14:18 ` [PATCH v2] " rrrrr4413
0 siblings, 2 replies; 6+ messages in thread
From: rrrrr4413 @ 2026-01-13 12:50 UTC (permalink / raw)
To: Borislav Petkov; +Cc: Thomas Gleixner, x86, linux-kernel, hpa, Yen-Hsiang Hsu
The comment for tag_to_ret_ctr in ibs_op_data says "15-31"
but it should be "16-31".
This just fixes the misleading comment. No functional changes.
Signed-off-by: Yen-Hsiang Hsu <rrrrr4413@gmail.com>
---
arch/x86/include/asm/amd/ibs.h | 2 +-
tools/arch/x86/include/asm/amd/ibs.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/amd/ibs.h b/arch/x86/include/asm/amd/ibs.h
index 3ee5903982c2..7d44881d1a28 100644
--- a/arch/x86/include/asm/amd/ibs.h
+++ b/arch/x86/include/asm/amd/ibs.h
@@ -77,7 +77,7 @@ union ibs_op_data {
__u64 val;
struct {
__u64 comp_to_ret_ctr:16, /* 0-15: op completion to retire count */
- tag_to_ret_ctr:16, /* 15-31: op tag to retire count */
+ tag_to_ret_ctr:16, /* 16-31: op tag to retire count */
reserved1:2, /* 32-33: reserved */
op_return:1, /* 34: return op */
op_brn_taken:1, /* 35: taken branch op */
diff --git a/tools/arch/x86/include/asm/amd/ibs.h b/tools/arch/x86/include/asm/amd/ibs.h
index cbce54fec7b9..25c00000f698 100644
--- a/tools/arch/x86/include/asm/amd/ibs.h
+++ b/tools/arch/x86/include/asm/amd/ibs.h
@@ -77,7 +77,7 @@ union ibs_op_data {
__u64 val;
struct {
__u64 comp_to_ret_ctr:16, /* 0-15: op completion to retire count */
- tag_to_ret_ctr:16, /* 15-31: op tag to retire count */
+ tag_to_ret_ctr:16, /* 16-31: op tag to retire count */
reserved1:2, /* 32-33: reserved */
op_return:1, /* 34: return op */
op_brn_taken:1, /* 35: taken branch op */
--
2.52.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] perf/x86/amd/ibs: Fix comment typo in ibs_op_data
2026-01-13 12:50 [PATCH] perf/x86/amd/ibs: Fix comment typo in ibs_op_data rrrrr4413
@ 2026-01-13 13:45 ` Borislav Petkov
2026-01-13 14:18 ` [PATCH v2] " rrrrr4413
1 sibling, 0 replies; 6+ messages in thread
From: Borislav Petkov @ 2026-01-13 13:45 UTC (permalink / raw)
To: rrrrr4413; +Cc: Thomas Gleixner, x86, linux-kernel, hpa
On Tue, Jan 13, 2026 at 08:50:04PM +0800, rrrrr4413@gmail.com wrote:
> The comment for tag_to_ret_ctr in ibs_op_data says "15-31"
> but it should be "16-31".
>
> This just fixes the misleading comment. No functional changes.
s/This just fixes/Fix/
> Signed-off-by: Yen-Hsiang Hsu <rrrrr4413@gmail.com>
> ---
> arch/x86/include/asm/amd/ibs.h | 2 +-
> tools/arch/x86/include/asm/amd/ibs.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Borislav Petkov (AMD) <bp@alien8.de>
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] perf/x86/amd/ibs: Fix comment typo in ibs_op_data
2026-01-13 12:50 [PATCH] perf/x86/amd/ibs: Fix comment typo in ibs_op_data rrrrr4413
2026-01-13 13:45 ` Borislav Petkov
@ 2026-01-13 14:18 ` rrrrr4413
2026-02-05 10:24 ` Yen-Hsiang Hsu
` (2 more replies)
1 sibling, 3 replies; 6+ messages in thread
From: rrrrr4413 @ 2026-01-13 14:18 UTC (permalink / raw)
To: Borislav Petkov, Thomas Gleixner; +Cc: x86, linux-kernel, hpa, Yen-Hsiang Hsu
The comment for tag_to_ret_ctr in ibs_op_data says "15-31"
but it should be "16-31".
Fix the misleading comment. No functional changes.
Signed-off-by: Yen-Hsiang Hsu <rrrrr4413@gmail.com>
Reviewed-by: Borislav Petkov (AMD) <bp@alien8.de>
---
v1 -> v2
I took Borislav's advice to fix commit message.
v1
Link: https://lore.kernel.org/lkml/20260113125004.3173384-1-rrrrr4413@gmail.com/
arch/x86/include/asm/amd/ibs.h | 2 +-
tools/arch/x86/include/asm/amd/ibs.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/amd/ibs.h b/arch/x86/include/asm/amd/ibs.h
index 3ee5903982c2..7d44881d1a28 100644
--- a/arch/x86/include/asm/amd/ibs.h
+++ b/arch/x86/include/asm/amd/ibs.h
@@ -77,7 +77,7 @@ union ibs_op_data {
__u64 val;
struct {
__u64 comp_to_ret_ctr:16, /* 0-15: op completion to retire count */
- tag_to_ret_ctr:16, /* 15-31: op tag to retire count */
+ tag_to_ret_ctr:16, /* 16-31: op tag to retire count */
reserved1:2, /* 32-33: reserved */
op_return:1, /* 34: return op */
op_brn_taken:1, /* 35: taken branch op */
diff --git a/tools/arch/x86/include/asm/amd/ibs.h b/tools/arch/x86/include/asm/amd/ibs.h
index cbce54fec7b9..25c00000f698 100644
--- a/tools/arch/x86/include/asm/amd/ibs.h
+++ b/tools/arch/x86/include/asm/amd/ibs.h
@@ -77,7 +77,7 @@ union ibs_op_data {
__u64 val;
struct {
__u64 comp_to_ret_ctr:16, /* 0-15: op completion to retire count */
- tag_to_ret_ctr:16, /* 15-31: op tag to retire count */
+ tag_to_ret_ctr:16, /* 16-31: op tag to retire count */
reserved1:2, /* 32-33: reserved */
op_return:1, /* 34: return op */
op_brn_taken:1, /* 35: taken branch op */
--
2.52.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] perf/x86/amd/ibs: Fix comment typo in ibs_op_data
2026-01-13 14:18 ` [PATCH v2] " rrrrr4413
@ 2026-02-05 10:24 ` Yen-Hsiang Hsu
2026-03-06 10:14 ` [tip: perf/core] " tip-bot2 for rrrrr4413@gmail.com
2026-03-06 10:41 ` tip-bot2 for Yen-Hsiang Hsu
2 siblings, 0 replies; 6+ messages in thread
From: Yen-Hsiang Hsu @ 2026-02-05 10:24 UTC (permalink / raw)
To: Borislav Petkov; +Cc: x86, linux-kernel
Hi boris,
Gentle ping.
Let me know if you need any changes.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [tip: perf/core] perf/x86/amd/ibs: Fix comment typo in ibs_op_data
2026-01-13 14:18 ` [PATCH v2] " rrrrr4413
2026-02-05 10:24 ` Yen-Hsiang Hsu
@ 2026-03-06 10:14 ` tip-bot2 for rrrrr4413@gmail.com
2026-03-06 10:41 ` tip-bot2 for Yen-Hsiang Hsu
2 siblings, 0 replies; 6+ messages in thread
From: tip-bot2 for rrrrr4413@gmail.com @ 2026-03-06 10:14 UTC (permalink / raw)
To: linux-tip-commits
Cc: Yen-Hsiang Hsu, Peter Zijlstra (Intel), Borislav Petkov (AMD),
x86, linux-kernel
The following commit has been merged into the perf/core branch of tip:
Commit-ID: f78f6b5bb82b6c430d649574fc85441f1a3c998e
Gitweb: https://git.kernel.org/tip/f78f6b5bb82b6c430d649574fc85441f1a3c998e
Author: rrrrr4413@gmail.com <rrrrr4413@gmail.com>
AuthorDate: Tue, 13 Jan 2026 22:18:30 +08:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Wed, 04 Mar 2026 17:06:13 +01:00
perf/x86/amd/ibs: Fix comment typo in ibs_op_data
The comment for tag_to_ret_ctr in ibs_op_data says "15-31"
but it should be "16-31".
Fix the misleading comment. No functional changes.
Signed-off-by: Yen-Hsiang Hsu <rrrrr4413@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://patch.msgid.link/20260113141830.3204114-1-rrrrr4413@gmail.com
---
arch/x86/include/asm/amd/ibs.h | 2 +-
tools/arch/x86/include/asm/amd/ibs.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/amd/ibs.h b/arch/x86/include/asm/amd/ibs.h
index 4eac36c..68e24a1 100644
--- a/arch/x86/include/asm/amd/ibs.h
+++ b/arch/x86/include/asm/amd/ibs.h
@@ -77,7 +77,7 @@ union ibs_op_data {
__u64 val;
struct {
__u64 comp_to_ret_ctr:16, /* 0-15: op completion to retire count */
- tag_to_ret_ctr:16, /* 15-31: op tag to retire count */
+ tag_to_ret_ctr:16, /* 16-31: op tag to retire count */
reserved1:2, /* 32-33: reserved */
op_return:1, /* 34: return op */
op_brn_taken:1, /* 35: taken branch op */
diff --git a/tools/arch/x86/include/asm/amd/ibs.h b/tools/arch/x86/include/asm/amd/ibs.h
index cbce54f..25c0000 100644
--- a/tools/arch/x86/include/asm/amd/ibs.h
+++ b/tools/arch/x86/include/asm/amd/ibs.h
@@ -77,7 +77,7 @@ union ibs_op_data {
__u64 val;
struct {
__u64 comp_to_ret_ctr:16, /* 0-15: op completion to retire count */
- tag_to_ret_ctr:16, /* 15-31: op tag to retire count */
+ tag_to_ret_ctr:16, /* 16-31: op tag to retire count */
reserved1:2, /* 32-33: reserved */
op_return:1, /* 34: return op */
op_brn_taken:1, /* 35: taken branch op */
^ permalink raw reply [flat|nested] 6+ messages in thread
* [tip: perf/core] perf/x86/amd/ibs: Fix comment typo in ibs_op_data
2026-01-13 14:18 ` [PATCH v2] " rrrrr4413
2026-02-05 10:24 ` Yen-Hsiang Hsu
2026-03-06 10:14 ` [tip: perf/core] " tip-bot2 for rrrrr4413@gmail.com
@ 2026-03-06 10:41 ` tip-bot2 for Yen-Hsiang Hsu
2 siblings, 0 replies; 6+ messages in thread
From: tip-bot2 for Yen-Hsiang Hsu @ 2026-03-06 10:41 UTC (permalink / raw)
To: linux-tip-commits
Cc: Yen-Hsiang Hsu, Peter Zijlstra (Intel), Borislav Petkov (AMD),
x86, linux-kernel
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 73cee0aad1ee2479fde2c9b753a1b66acb7d1b9a
Gitweb: https://git.kernel.org/tip/73cee0aad1ee2479fde2c9b753a1b66acb7d1b9a
Author: Yen-Hsiang Hsu <rrrrr4413@gmail.com>
AuthorDate: Tue, 13 Jan 2026 22:18:30 +08:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Fri, 06 Mar 2026 11:37:59 +01:00
perf/x86/amd/ibs: Fix comment typo in ibs_op_data
The comment for tag_to_ret_ctr in ibs_op_data says "15-31"
but it should be "16-31".
Fix the misleading comment. No functional changes.
Signed-off-by: Yen-Hsiang Hsu <rrrrr4413@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://patch.msgid.link/20260113141830.3204114-1-rrrrr4413@gmail.com
---
arch/x86/include/asm/amd/ibs.h | 2 +-
tools/arch/x86/include/asm/amd/ibs.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/amd/ibs.h b/arch/x86/include/asm/amd/ibs.h
index 4eac36c..68e24a1 100644
--- a/arch/x86/include/asm/amd/ibs.h
+++ b/arch/x86/include/asm/amd/ibs.h
@@ -77,7 +77,7 @@ union ibs_op_data {
__u64 val;
struct {
__u64 comp_to_ret_ctr:16, /* 0-15: op completion to retire count */
- tag_to_ret_ctr:16, /* 15-31: op tag to retire count */
+ tag_to_ret_ctr:16, /* 16-31: op tag to retire count */
reserved1:2, /* 32-33: reserved */
op_return:1, /* 34: return op */
op_brn_taken:1, /* 35: taken branch op */
diff --git a/tools/arch/x86/include/asm/amd/ibs.h b/tools/arch/x86/include/asm/amd/ibs.h
index cbce54f..25c0000 100644
--- a/tools/arch/x86/include/asm/amd/ibs.h
+++ b/tools/arch/x86/include/asm/amd/ibs.h
@@ -77,7 +77,7 @@ union ibs_op_data {
__u64 val;
struct {
__u64 comp_to_ret_ctr:16, /* 0-15: op completion to retire count */
- tag_to_ret_ctr:16, /* 15-31: op tag to retire count */
+ tag_to_ret_ctr:16, /* 16-31: op tag to retire count */
reserved1:2, /* 32-33: reserved */
op_return:1, /* 34: return op */
op_brn_taken:1, /* 35: taken branch op */
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-03-06 10:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-13 12:50 [PATCH] perf/x86/amd/ibs: Fix comment typo in ibs_op_data rrrrr4413
2026-01-13 13:45 ` Borislav Petkov
2026-01-13 14:18 ` [PATCH v2] " rrrrr4413
2026-02-05 10:24 ` Yen-Hsiang Hsu
2026-03-06 10:14 ` [tip: perf/core] " tip-bot2 for rrrrr4413@gmail.com
2026-03-06 10:41 ` tip-bot2 for Yen-Hsiang Hsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®