* [PATCH v2] staging: rtl8723bs: fix inconsistent indenting detected by smatch
@ 2026-02-08 17:02 Filippo Muscherà
2026-02-21 14:49 ` Bera Yüzlü
0 siblings, 1 reply; 2+ messages in thread
From: Filippo Muscherà @ 2026-02-08 17:02 UTC (permalink / raw)
To: gregkh
Cc: linux-staging, linux-kernel, b9788213, straube.linux,
Filippo Muscherà
Fix the following inconsistent indentation warnings reported by Smatch:
drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c:2319
EXhalbtc8723b1ant_ConnectNotify(): inconsistent indenting
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c:1410
phy_IQCalibrate_8723B(): inconsistent indenting
The affected code used a mix of tabs and spaces or excessive
indentation, making it misleading to read. Align the lines with the
surrounding code using tabs.
While at it, wrap long lines in HalPhyRf_8723B.c to silence checkpatch
warnings.
Signed-off-by: Filippo Muscherà <filippo.muschera@gmail.com>
---
v2:
- Fix coding style issues introduced in v1 when wrapping lines.
---
drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 2 +-
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 6 ++++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
index b3d7f50fac4c..1af101ba9752 100644
--- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
+++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
@@ -2316,7 +2316,7 @@ void EXhalbtc8723b1ant_ConnectNotify(struct btc_coexist *pBtCoexist, u8 type)
if (type == BTC_ASSOCIATE_START) {
pCoexSta->bWiFiIsHighPriTask = true;
- pCoexDm->nArpCnt = 0;
+ pCoexDm->nArpCnt = 0;
} else {
pCoexSta->bWiFiIsHighPriTask = false;
/* pCoexDm->nArpCnt = 0; */
diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
index 9df3274c1048..eea44e390270 100644
--- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
+++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
@@ -1407,8 +1407,10 @@ static void phy_IQCalibrate_8723B(
PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_IQK, bMaskH3Bytes, 0x000000);
pDM_Odm->RFCalibrateInfo.TxLOK[RF_PATH_A] = PHY_QueryRFReg(pDM_Odm->Adapter, RF_PATH_A, 0x8, bRFRegOffsetMask);
- result[t][0] = (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_Before_IQK_A, bMaskDWord)&0x3FF0000)>>16;
- result[t][1] = (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_After_IQK_A, bMaskDWord)&0x3FF0000)>>16;
+ result[t][0] = (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_Before_IQK_A,
+ bMaskDWord) & 0x3FF0000) >> 16;
+ result[t][1] = (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_After_IQK_A,
+ bMaskDWord) & 0x3FF0000) >> 16;
break;
}
}
--
2.52.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: fix inconsistent indenting detected by smatch
2026-02-08 17:02 [PATCH v2] staging: rtl8723bs: fix inconsistent indenting detected by smatch Filippo Muscherà
@ 2026-02-21 14:49 ` Bera Yüzlü
0 siblings, 0 replies; 2+ messages in thread
From: Bera Yüzlü @ 2026-02-21 14:49 UTC (permalink / raw)
To: Filippo Muscherà; +Cc: gregkh, linux-staging, linux-kernel, straube.linux
On Sun, Feb 08, 2026 at 06:02:47PM +0100, Filippo Muscherà wrote:
> Fix the following inconsistent indentation warnings reported by Smatch:
>
> drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c:2319
> EXhalbtc8723b1ant_ConnectNotify(): inconsistent indenting
> drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c:1410
> phy_IQCalibrate_8723B(): inconsistent indenting
>
> The affected code used a mix of tabs and spaces or excessive
> indentation, making it misleading to read. Align the lines with the
> surrounding code using tabs.
>
> While at it, wrap long lines in HalPhyRf_8723B.c to silence checkpatch
> warnings.
>
> Signed-off-by: Filippo Muscherà <filippo.muschera@gmail.com>
> ---
LGTM.
Reviewed-by: Bera Yüzlü <b9788213@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-21 14:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-08 17:02 [PATCH v2] staging: rtl8723bs: fix inconsistent indenting detected by smatch Filippo Muscherà
2026-02-21 14:49 ` Bera Yüzlü
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®