From: Markus Elfring <Markus.Elfring@web.de>
To: "Christian König" <christian.koenig@amd.com>,
赵军奎 <bernard@vivo.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Chunming Zhou" <David1.Zhou@amd.com>,
"Felix Kühling" <Felix.Kuehling@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
opensource.kernel@vivo.com, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [V3] amdgpu: remove unnecessary condition check
Date: Tue, 21 Apr 2020 12:00:12 +0200 [thread overview]
Message-ID: <aa0a34ce-714f-a637-d1a8-54de94a09e75@web.de> (raw)
In-Reply-To: <ccd14dee-f275-5de4-b5c1-4f359d155288@amd.com>
>> But i have to say there are so many code not follow the kernel code-style in amdgpu module.
>> And also the ./scripts/checkpatch.pl did not throw any warning or error.
>
> That is unfortunately true, yes. But we try to push new code through the usual code review and improve things as we go.
>
> On the other hand patches just to fix the coding style are usually seen as an unnecessary interruption and just a waste of time.
Would you become interested in adjusting deviations from known programming guidelines
in an automatic way with the help of corresponding advanced development tools?
Regards,
Markus
next prev parent reply other threads:[~2020-04-21 10:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 8:03 [PATCH V3] " Bernard Zhao
2020-04-21 8:06 ` Christian König
2020-04-21 8:44 ` 赵军奎
2020-04-21 9:34 ` [V3] " Markus Elfring
2020-04-21 9:48 ` [PATCH V3] " Christian König
2020-04-21 10:00 ` Markus Elfring [this message]
2020-04-21 11:12 ` [V3] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa0a34ce-714f-a637-d1a8-54de94a09e75@web.de \
--to=markus.elfring@web.de \
--cc=David1.Zhou@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bernard@vivo.com \
--cc=christian.koenig@amd.com \
--cc=cocci@systeme.lip6.fr \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®