From: Markus Elfring <Markus.Elfring@web.de>
To: 赵军奎 <bernard@vivo.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: opensource.kernel@vivo.com, linux-kernel@vger.kernel.org,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Chunming Zhou" <David1.Zhou@amd.com>,
"Felix Kühling" <Felix.Kuehling@amd.com>
Subject: Re: [V3] amdgpu: remove unnecessary condition check
Date: Tue, 21 Apr 2020 13:12:27 +0200 [thread overview]
Message-ID: <c12c2bfe-785a-3279-721e-3efd2e0f7b2c@web.de> (raw)
In-Reply-To: <AIsA-wCZCFCxiq0WKb3WjKr*.3.1587458683834.Hmail.bernard@vivo.com>
>>> There is no need to if check again, maybe we could merge
>>> into the above else branch.
I find also this commit message still improvable (besides the mentioned
implementation details around coding style concerns).
How will corresponding review comments be taken better into account?
Regards,
Markus
prev parent reply other threads:[~2020-04-21 11:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 8:03 [PATCH V3] " Bernard Zhao
2020-04-21 8:06 ` Christian König
2020-04-21 8:44 ` 赵军奎
2020-04-21 9:34 ` [V3] " Markus Elfring
2020-04-21 9:48 ` [PATCH V3] " Christian König
2020-04-21 10:00 ` [V3] " Markus Elfring
2020-04-21 11:12 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c12c2bfe-785a-3279-721e-3efd2e0f7b2c@web.de \
--to=markus.elfring@web.de \
--cc=David1.Zhou@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bernard@vivo.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®