From: Hridesh MG <hridesh699@gmail.com>
To: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: hridesh <hridesh699@gmail.com>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Jens Axboe" <axboe@kernel.dk>,
"Matt Gilbride" <mattgilbride@google.com>,
"Shuah Khan" <skhan@linuxfoundation.org>
Subject: [PATCH v2 1/2] rust: kernel: clean up empty `///` lines
Date: Wed, 11 Sep 2024 23:14:34 +0530 [thread overview]
Message-ID: <aa1b4059dfac001945745db02b6f6d9db2e5d1cb.1726072795.git.hridesh699@gmail.com> (raw)
From: hridesh <hridesh699@gmail.com>
Remove unnecessary empty `///` lines in the rust docs.
Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1109
Signed-off-by: Hridesh MG <hridesh699@gmail.com>
---
Changes in v2:
- Fixed typo in commit title and description
- Removed backslashes in kernel::block::mq::Request
- Link to v1: https://lore.kernel.org/rust-for-linux/20240909161749.147076-1-hridesh699@gmail.com/
Huge thanks to Benno Lossin and Miguel Ojeda for taking the time to
review my first patch
---
rust/kernel/block/mq/request.rs | 1 -
rust/kernel/rbtree.rs | 1 -
2 files changed, 2 deletions(-)
diff --git a/rust/kernel/block/mq/request.rs b/rust/kernel/block/mq/request.rs
index a0e22827f3f4..313334b1bf18 100644
--- a/rust/kernel/block/mq/request.rs
+++ b/rust/kernel/block/mq/request.rs
@@ -30,7 +30,6 @@
/// D) Request is owned by driver with more than one `ARef` in existence
/// (refcount > 2)
///
-///
/// We need to track A and B to ensure we fail tag to request conversions for
/// requests that are not owned by the driver.
///
diff --git a/rust/kernel/rbtree.rs b/rust/kernel/rbtree.rs
index 25eb36fd1cdc..006f6e03aba5 100644
--- a/rust/kernel/rbtree.rs
+++ b/rust/kernel/rbtree.rs
@@ -1031,7 +1031,6 @@ fn next(&mut self) -> Option<Self::Item> {
/// A memory reservation for a red-black tree node.
///
-///
/// It contains the memory needed to hold a node that can be inserted into a red-black tree. One
/// can be obtained by directly allocating it ([`RBTreeNodeReservation::new`]).
pub struct RBTreeNodeReservation<K, V> {
--
2.46.0
WARNING: multiple messages have this Message-ID
From: Hridesh MG <hridesh699@gmail.com>
To: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Hridesh MG" <hridesh699@gmail.com>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Jens Axboe" <axboe@kernel.dk>,
"Matt Gilbride" <mattgilbride@google.com>,
"Shuah Khan" <skhan@linuxfoundation.org>
Subject: [PATCH v3 1/2] rust: kernel: clean up empty `///` lines
Date: Sat, 14 Sep 2024 20:54:28 +0530 [thread overview]
Message-ID: <aa1b4059dfac001945745db02b6f6d9db2e5d1cb.1726072795.git.hridesh699@gmail.com> (raw)
Message-ID: <20240914152428.u32yuCTM6nT24H6OgMkga-l49sLp4eUxGWfhVF5gqcg@z> (raw)
Remove unnecessary empty `///` lines in the rust docs.
Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1109
Signed-off-by: Hridesh MG <hridesh699@gmail.com>
---
Changes in v2:
- Fixed typo in commit title and description
- Removed backslashes in kernel::block::mq::Request
- Link to v1: https://lore.kernel.org/rust-for-linux/20240909161749.147076-1-hridesh699@gmail.com/
Changes in v3:
- Fixed From: tag in patch header
---
rust/kernel/block/mq/request.rs | 1 -
rust/kernel/rbtree.rs | 1 -
2 files changed, 2 deletions(-)
diff --git a/rust/kernel/block/mq/request.rs b/rust/kernel/block/mq/request.rs
index a0e22827f3f4..313334b1bf18 100644
--- a/rust/kernel/block/mq/request.rs
+++ b/rust/kernel/block/mq/request.rs
@@ -30,7 +30,6 @@
/// D) Request is owned by driver with more than one `ARef` in existence
/// (refcount > 2)
///
-///
/// We need to track A and B to ensure we fail tag to request conversions for
/// requests that are not owned by the driver.
///
diff --git a/rust/kernel/rbtree.rs b/rust/kernel/rbtree.rs
index 25eb36fd1cdc..006f6e03aba5 100644
--- a/rust/kernel/rbtree.rs
+++ b/rust/kernel/rbtree.rs
@@ -1031,7 +1031,6 @@ fn next(&mut self) -> Option<Self::Item> {
/// A memory reservation for a red-black tree node.
///
-///
/// It contains the memory needed to hold a node that can be inserted into a red-black tree. One
/// can be obtained by directly allocating it ([`RBTreeNodeReservation::new`]).
pub struct RBTreeNodeReservation<K, V> {
--
2.46.0
next reply other threads:[~2024-09-11 17:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 17:44 Hridesh MG [this message]
2024-09-11 17:44 ` [PATCH v2 2/2] checkpatch: warn on empty rust doc comments Hridesh MG
2024-09-14 15:24 ` [PATCH v3 " Hridesh MG
2024-09-14 15:31 ` Hridesh MG
2024-09-14 16:42 ` Gary Guo
2024-09-14 16:57 ` Hridesh MG
2024-09-12 5:13 ` [PATCH v2 1/2] rust: kernel: clean up empty `///` lines Greg KH
2024-09-12 11:46 ` Hridesh MG
2024-09-12 11:50 ` Alice Ryhl
2024-09-14 15:24 ` [PATCH v3 " Hridesh MG
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa1b4059dfac001945745db02b6f6d9db2e5d1cb.1726072795.git.hridesh699@gmail.com \
--to=hridesh699@gmail.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=axboe@kernel.dk \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mattgilbride@google.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tmgross@umich.edu \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®