From: Timur Tabi <ttabi@nvidia.com>
To: "lyude@redhat.com" <lyude@redhat.com>,
"dawei.feng@seu.edu.cn" <dawei.feng@seu.edu.cn>
Cc: "jianhao.xu@seu.edu.cn" <jianhao.xu@seu.edu.cn>,
"zilin@seu.edu.cn" <zilin@seu.edu.cn>,
"namcao@linutronix.de" <namcao@linutronix.de>,
"simona@ffwll.ch" <simona@ffwll.ch>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"dakr@kernel.org" <dakr@kernel.org>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"mripard@kernel.org" <mripard@kernel.org>
Subject: Re: [PATCH] nouveau/firmware: fix memory leak on BL load failure
Date: Fri, 5 Jun 2026 18:22:41 +0000 [thread overview]
Message-ID: <aa2e39a828634f20852d066f593f26510fbdc2d9.camel@nvidia.com> (raw)
In-Reply-To: <20260605020752.1707562-1-dawei.feng@seu.edu.cn>
On Fri, 2026-06-05 at 10:07 +0800, Dawei Feng wrote:
> if (bl) {
> nvkm_firmware_put(blob);
> + blob = NULL;
>
I think it would be cleaner to instead delete this nvkm_firmware_put(blob) call here, and just rely
on the call to nvkm_firmware_put() at the end of nvkm_falcon_fw_ctor_hs(). Then you won't need
"blob = NULL".
next prev parent reply other threads:[~2026-06-05 18:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 2:07 Dawei Feng
2026-06-05 18:22 ` Timur Tabi [this message]
2026-06-08 13:52 ` Dawei Feng
2026-06-08 17:53 ` Timur Tabi
2026-06-09 8:57 ` Dawei Feng
2026-06-09 15:00 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa2e39a828634f20852d066f593f26510fbdc2d9.camel@nvidia.com \
--to=ttabi@nvidia.com \
--cc=dakr@kernel.org \
--cc=dawei.feng@seu.edu.cn \
--cc=dri-devel@lists.freedesktop.org \
--cc=jianhao.xu@seu.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=namcao@linutronix.de \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
--cc=zilin@seu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®