From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, Ingo Molnar <mingo@elte.hu>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [Question] x86,APIC: In apicdef.h dfr,svr,...... shouldn't be const?
Date: Tue, 1 Sep 2009 12:43:06 +0400 [thread overview]
Message-ID: <aa79d98a0909010143t27096d25n1ee36651f8487b52@mail.gmail.com> (raw)
In-Reply-To: <b9df5fa10908312248x6a8946f5jfbe972f3358baad3@mail.gmail.com>
On 9/1/09, Rakib Mullick <rakib.mullick@gmail.com> wrote:
> Hello guys, Intel System programmers guide says - dfr, svr, esr - this
> registers should be readonly. So shouldn't they use const? Or is it
> anything else?
Hi Rakib, i dont have sources under my hands at moment, but iirc there
were situations we nees to poke esr register.
>
> And apicdef.h also contains a style problem, checkpatch warns about
> following style:
>
> u32 spurious_vector : 8
>
> Check patch wants as:
>
> u32 spurious_vector:8
>
> Shouldn't this issues be fixed?
>
> Thanks,
> --
i dont see reason why not ;)
though i wonder why we need this structure at all. We may have
extended amd entries.
Yinghai cced.
next prev parent reply other threads:[~2009-09-01 8:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 5:48 Rakib Mullick
2009-09-01 8:43 ` Cyrill Gorcunov [this message]
2009-09-01 19:41 ` Cyrill Gorcunov
2009-09-02 2:17 ` Maciej W. Rozycki
2009-09-03 22:56 ` Rakib Mullick
2009-09-03 23:21 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa79d98a0909010143t27096d25n1ee36651f8487b52@mail.gmail.com \
--to=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rakib.mullick@gmail.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®