* [PATCH] clk: mediatek: clk-mt7986-infracfg: delete the code related to 'base'
@ 2023-04-07 8:37 Xinyi Hou
2023-04-12 11:50 ` Alexandre Mergnat
0 siblings, 1 reply; 2+ messages in thread
From: Xinyi Hou @ 2023-04-07 8:37 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: Xinyi Hou, Dongliang Mu, linux-clk, linux-kernel,
linux-arm-kernel, linux-mediatek
In clk_mt7986_infracfg_probe(), 'base' is allocated but never used,
either not released on both success failure path.
Fix this by deleting 'base' and the code related to it.
Signed-off-by: Xinyi Hou <Y_Ashley@163.com>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
---
drivers/clk/mediatek/clk-mt7986-infracfg.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/clk/mediatek/clk-mt7986-infracfg.c b/drivers/clk/mediatek/clk-mt7986-infracfg.c
index e80c92167c8f..76b32f3a16b2 100644
--- a/drivers/clk/mediatek/clk-mt7986-infracfg.c
+++ b/drivers/clk/mediatek/clk-mt7986-infracfg.c
@@ -174,16 +174,9 @@ static int clk_mt7986_infracfg_probe(struct platform_device *pdev)
struct clk_hw_onecell_data *clk_data;
struct device_node *node = pdev->dev.of_node;
int r;
- void __iomem *base;
int nr = ARRAY_SIZE(infra_divs) + ARRAY_SIZE(infra_muxes) +
ARRAY_SIZE(infra_clks);
- base = of_iomap(node, 0);
- if (!base) {
- pr_err("%s(): ioremap failed\n", __func__);
- return -ENOMEM;
- }
-
clk_data = mtk_alloc_clk_data(nr);
if (!clk_data)
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] clk: mediatek: clk-mt7986-infracfg: delete the code related to 'base'
2023-04-07 8:37 [PATCH] clk: mediatek: clk-mt7986-infracfg: delete the code related to 'base' Xinyi Hou
@ 2023-04-12 11:50 ` Alexandre Mergnat
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Mergnat @ 2023-04-12 11:50 UTC (permalink / raw)
To: Xinyi Hou, Michael Turquette, Stephen Boyd, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: Dongliang Mu, linux-clk, linux-kernel, linux-arm-kernel, linux-mediatek
On 07/04/2023 10:37, Xinyi Hou wrote:
> In clk_mt7986_infracfg_probe(), 'base' is allocated but never used,
> either not released on both success failure path.
>
> Fix this by deleting 'base' and the code related to it.
>
> Signed-off-by: Xinyi Hou<Y_Ashley@163.com>
> Reviewed-by: Dongliang Mu<dzm91@hust.edu.cn>
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
--
Regards,
Alexandre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-12 11:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-07 8:37 [PATCH] clk: mediatek: clk-mt7986-infracfg: delete the code related to 'base' Xinyi Hou
2023-04-12 11:50 ` Alexandre Mergnat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®