* [PATCH v1 1/2] arm64: dts: imx8mm-verdin: update CAN clock to 40MHz
2022-07-08 12:42 [PATCH v1 0/2] arm64: dts: imx8mm-verdin: update CAN clock and interrupt type Andrejs Cainikovs
@ 2022-07-08 12:42 ` Andrejs Cainikovs
2022-07-13 7:57 ` Marcel Ziswiler
2022-07-08 12:42 ` [PATCH v1 2/2] arm64: dts: imx8mm-verdin: use level interrupt for mcp251xfd Andrejs Cainikovs
2022-07-29 10:49 ` [PATCH v1 0/2] arm64: dts: imx8mm-verdin: update CAN clock and interrupt type Francesco Dolcini
2 siblings, 1 reply; 7+ messages in thread
From: Andrejs Cainikovs @ 2022-07-08 12:42 UTC (permalink / raw)
To: Marc Kleine-Budde, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team
Cc: devicetree, linux-arm-kernel, linux-kernel, Francesco Dolcini,
Marcel Ziswiler, Andrejs Cainikovs
Update SPI CAN controller clock to match current hardware design.
Signed-off-by: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
---
arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
index eafa88d980b3..2841c6bfe3a9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
@@ -32,10 +32,10 @@ backlight: backlight {
};
/* Fixed clock dedicated to SPI CAN controller */
- clk20m: oscillator {
+ clk40m: oscillator {
compatible = "fixed-clock";
#clock-cells = <0>;
- clock-frequency = <20000000>;
+ clock-frequency = <40000000>;
};
gpio-keys {
@@ -194,7 +194,7 @@ &ecspi3 {
can1: can@0 {
compatible = "microchip,mcp251xfd";
- clocks = <&clk20m>;
+ clocks = <&clk40m>;
interrupts-extended = <&gpio1 6 IRQ_TYPE_EDGE_FALLING>;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_can1_int>;
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1 1/2] arm64: dts: imx8mm-verdin: update CAN clock to 40MHz
2022-07-08 12:42 ` [PATCH v1 1/2] arm64: dts: imx8mm-verdin: update CAN clock to 40MHz Andrejs Cainikovs
@ 2022-07-13 7:57 ` Marcel Ziswiler
0 siblings, 0 replies; 7+ messages in thread
From: Marcel Ziswiler @ 2022-07-13 7:57 UTC (permalink / raw)
To: kernel, linux-imx, s.hauer, festevam, Andrejs Cainikovs,
shawnguo, mkl, krzysztof.kozlowski+dt, robh+dt
Cc: linux-arm-kernel, devicetree, linux-kernel, Francesco Dolcini
On Fri, 2022-07-08 at 14:42 +0200, Andrejs Cainikovs wrote:
> Update SPI CAN controller clock to match current hardware design.
>
> Signed-off-by: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-
> verdin.dtsi
> index eafa88d980b3..2841c6bfe3a9 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> @@ -32,10 +32,10 @@ backlight: backlight {
> };
>
> /* Fixed clock dedicated to SPI CAN controller */
> - clk20m: oscillator {
> + clk40m: oscillator {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> - clock-frequency = <20000000>;
> + clock-frequency = <40000000>;
> };
>
> gpio-keys {
> @@ -194,7 +194,7 @@ &ecspi3 {
>
> can1: can@0 {
> compatible = "microchip,mcp251xfd";
> - clocks = <&clk20m>;
> + clocks = <&clk40m>;
> interrupts-extended = <&gpio1 6 IRQ_TYPE_EDGE_FALLING>;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_can1_int>;
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v1 2/2] arm64: dts: imx8mm-verdin: use level interrupt for mcp251xfd
2022-07-08 12:42 [PATCH v1 0/2] arm64: dts: imx8mm-verdin: update CAN clock and interrupt type Andrejs Cainikovs
2022-07-08 12:42 ` [PATCH v1 1/2] arm64: dts: imx8mm-verdin: update CAN clock to 40MHz Andrejs Cainikovs
@ 2022-07-08 12:42 ` Andrejs Cainikovs
2022-07-10 19:25 ` Marc Kleine-Budde
2022-07-29 10:49 ` [PATCH v1 0/2] arm64: dts: imx8mm-verdin: update CAN clock and interrupt type Francesco Dolcini
2 siblings, 1 reply; 7+ messages in thread
From: Andrejs Cainikovs @ 2022-07-08 12:42 UTC (permalink / raw)
To: Marc Kleine-Budde, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team
Cc: devicetree, linux-arm-kernel, linux-kernel, Francesco Dolcini,
Marcel Ziswiler, Andrejs Cainikovs
Switch to level interrupt for mcp251xfd. This will make sure no
interrupts are lost.
Signed-off-by: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
---
arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
index 2841c6bfe3a9..6491e745b3fa 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
@@ -195,7 +195,7 @@ &ecspi3 {
can1: can@0 {
compatible = "microchip,mcp251xfd";
clocks = <&clk40m>;
- interrupts-extended = <&gpio1 6 IRQ_TYPE_EDGE_FALLING>;
+ interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_LOW>;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_can1_int>;
reg = <0>;
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1 2/2] arm64: dts: imx8mm-verdin: use level interrupt for mcp251xfd
2022-07-08 12:42 ` [PATCH v1 2/2] arm64: dts: imx8mm-verdin: use level interrupt for mcp251xfd Andrejs Cainikovs
@ 2022-07-10 19:25 ` Marc Kleine-Budde
0 siblings, 0 replies; 7+ messages in thread
From: Marc Kleine-Budde @ 2022-07-10 19:25 UTC (permalink / raw)
To: Andrejs Cainikovs
Cc: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
devicetree, linux-arm-kernel, linux-kernel, Francesco Dolcini,
Marcel Ziswiler
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
On 08.07.2022 14:42:05, Andrejs Cainikovs wrote:
> Switch to level interrupt for mcp251xfd. This will make sure no
> interrupts are lost.
>
> Signed-off-by: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
Reported-by: Marc Kleine-Budde <mkl@pengutronix.de>
as per https://lore.kernel.org/linux-arm-kernel/20220621195046.rnv66d2333wjmtow@pengutronix.de
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 0/2] arm64: dts: imx8mm-verdin: update CAN clock and interrupt type
2022-07-08 12:42 [PATCH v1 0/2] arm64: dts: imx8mm-verdin: update CAN clock and interrupt type Andrejs Cainikovs
2022-07-08 12:42 ` [PATCH v1 1/2] arm64: dts: imx8mm-verdin: update CAN clock to 40MHz Andrejs Cainikovs
2022-07-08 12:42 ` [PATCH v1 2/2] arm64: dts: imx8mm-verdin: use level interrupt for mcp251xfd Andrejs Cainikovs
@ 2022-07-29 10:49 ` Francesco Dolcini
2022-08-17 9:24 ` Shawn Guo
2 siblings, 1 reply; 7+ messages in thread
From: Francesco Dolcini @ 2022-07-29 10:49 UTC (permalink / raw)
To: Shawn Guo
Cc: Marc Kleine-Budde, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel, linux-kernel,
Francesco Dolcini, Marcel Ziswiler, Andrejs Cainikovs
Hello Shawn,
just a gently ping.
On Fri, Jul 08, 2022 at 02:42:03PM +0200, Andrejs Cainikovs wrote:
> This patch set updates CAN controller clock and changes interrupt type.
>
> Andrejs Cainikovs (2):
> arm64: dts: imx8mm-verdin: update CAN clock to 40MHz
> arm64: dts: imx8mm-verdin: use level interrupt for mcp251xfd
>
> arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
It's too late for the merge window? These 2 commits do not have a fixes
tag, but they are really fixes (we just did not bother having those
backported initially).
Francesco
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 0/2] arm64: dts: imx8mm-verdin: update CAN clock and interrupt type
2022-07-29 10:49 ` [PATCH v1 0/2] arm64: dts: imx8mm-verdin: update CAN clock and interrupt type Francesco Dolcini
@ 2022-08-17 9:24 ` Shawn Guo
0 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2022-08-17 9:24 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Marc Kleine-Budde, Rob Herring, Krzysztof Kozlowski,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel,
Linux Kernel Mailing List, Marcel Ziswiler, Andrejs Cainikovs
On Fri, Jul 29, 2022 at 6:49 PM Francesco Dolcini
<francesco.dolcini@toradex.com> wrote:
>
> Hello Shawn,
> just a gently ping.
>
> On Fri, Jul 08, 2022 at 02:42:03PM +0200, Andrejs Cainikovs wrote:
> > This patch set updates CAN controller clock and changes interrupt type.
> >
> > Andrejs Cainikovs (2):
> > arm64: dts: imx8mm-verdin: update CAN clock to 40MHz
> > arm64: dts: imx8mm-verdin: use level interrupt for mcp251xfd
> >
> > arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> It's too late for the merge window? These 2 commits do not have a fixes
> tag, but they are really fixes (we just did not bother having those
> backported initially).
Applied both as fixes, thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread