From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Priit Laes <plaes@plaes.org>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com
Subject: Re: [PATCH 0/5] Use common cordic algorithm for b43
Date: Mon, 5 Nov 2018 09:24:16 +0100 [thread overview]
Message-ID: <aac01237-6736-e786-b11c-4586ebb25dd1@broadcom.com> (raw)
In-Reply-To: <cover.f21c8e62e188620d586edb3f77514e6237122c4c.1541238842.git-series.plaes@plaes.org>
On 11/3/2018 10:59 AM, Priit Laes wrote:
> b43 wireless driver included internal implementation of cordic
> algorithm which has now been removed in favor of library
> implementation.
>
> During the process, brcmfmac was driver was also cleaned.
You actually touched the *brcmsmac* driver, not brcmfmac. Please fix the
driver prefix where appropriate in this series, ie. patches 2 and 3.
> Please note that this series is only compile-tested, as I
> do not have access to the hardware.
I can/will verify brcmsmac. As Kalle mentioned it makes more sense to
push the 'lib: cordic:' patch through the wireless tree as well as it
only is used by wireless drivers right now.
Regards,
Arend
prev parent reply other threads:[~2018-11-05 8:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-03 9:59 Priit Laes
2018-11-03 9:59 ` [PATCH 1/5] lib: cordic: Move cordic macros and defines to header file Priit Laes
2018-11-03 9:59 ` [PATCH 2/5] brcmfmac: Use common CORDIC_FLOAT macro from lib Priit Laes
2018-11-05 9:05 ` Kalle Valo
2018-11-05 9:13 ` Arend van Spriel
2018-11-03 9:59 ` [PATCH 3/5] brcmfmac: Drop unused cordic defines and macros Priit Laes
2018-11-05 9:07 ` Kalle Valo
2018-11-03 9:59 ` [PATCH 4/5] b43: Use common cordic algorithm from kernel lib Priit Laes
2018-11-03 17:37 ` Larry Finger
2018-11-03 9:59 ` [PATCH 5/5] b43: Drop internal cordic algorithm implementation Priit Laes
2018-11-05 9:09 ` Kalle Valo
2018-11-05 9:11 ` Arend van Spriel
2018-11-05 8:02 ` [PATCH 0/5] Use common cordic algorithm for b43 Kalle Valo
2018-11-05 8:07 ` Kalle Valo
2018-11-05 8:17 ` Arend van Spriel
2018-11-05 9:02 ` Kalle Valo
2018-11-05 8:24 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aac01237-6736-e786-b11c-4586ebb25dd1@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=b43-dev@lists.infradead.org \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=plaes@plaes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome