From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>, Priit Laes <plaes@plaes.org>
Cc: linux-kernel@vger.kernel.org,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
Wright Feng <wright.feng@cypress.com>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/5] brcmfmac: Use common CORDIC_FLOAT macro from lib
Date: Mon, 5 Nov 2018 10:13:47 +0100 [thread overview]
Message-ID: <21e6a75b-7728-761d-d899-395864226fb5@broadcom.com> (raw)
In-Reply-To: <877ehrhp21.fsf@codeaurora.org>
On 11/5/2018 10:05 AM, Kalle Valo wrote:
> Priit Laes <plaes@plaes.org> writes:
>
>> Now that cordic library has the CORDIC_FLOAT macro, use that
>>
>> Signed-off-by: Priit Laes <plaes@plaes.org>
>> ---
>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 4 ++--
>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 4 ++--
>
> The driver is "brcmsmac" (note the 's', not 'f'), you should fix the
> title accordingly.
>
>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c
>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c
>> @@ -3447,8 +3447,8 @@ wlc_lcnphy_start_tx_tone(struct brcms_phy *pi, s32 f_kHz, u16 max_val,
>>
>> theta += rot;
>>
>> - i_samp = (u16) (FLOAT(tone_samp.i * max_val) & 0x3ff);
>> - q_samp = (u16) (FLOAT(tone_samp.q * max_val) & 0x3ff);
>> + i_samp = (u16)(CORDIC_FLOAT(tone_samp.i * max_val) & 0x3ff);
>> + q_samp = (u16)(CORDIC_FLOAT(tone_samp.q * max_val) & 0x3ff);
>
> I haven't seen the patch 1 yet, but just from seeing this patch I don't
> get what's the benefit.
The FLOAT macro was defined in brcmsmac (see patch 3). It is now moved
to the cordic library simply because it is more closely related to that.
Regards,
Arend
next prev parent reply other threads:[~2018-11-05 9:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-03 9:59 [PATCH 0/5] Use common cordic algorithm for b43 Priit Laes
2018-11-03 9:59 ` [PATCH 1/5] lib: cordic: Move cordic macros and defines to header file Priit Laes
2018-11-03 9:59 ` [PATCH 2/5] brcmfmac: Use common CORDIC_FLOAT macro from lib Priit Laes
2018-11-05 9:05 ` Kalle Valo
2018-11-05 9:13 ` Arend van Spriel [this message]
2018-11-03 9:59 ` [PATCH 3/5] brcmfmac: Drop unused cordic defines and macros Priit Laes
2018-11-05 9:07 ` Kalle Valo
2018-11-03 9:59 ` [PATCH 4/5] b43: Use common cordic algorithm from kernel lib Priit Laes
2018-11-03 17:37 ` Larry Finger
2018-11-03 9:59 ` [PATCH 5/5] b43: Drop internal cordic algorithm implementation Priit Laes
2018-11-05 9:09 ` Kalle Valo
2018-11-05 9:11 ` Arend van Spriel
2018-11-05 8:02 ` [PATCH 0/5] Use common cordic algorithm for b43 Kalle Valo
2018-11-05 8:07 ` Kalle Valo
2018-11-05 8:17 ` Arend van Spriel
2018-11-05 9:02 ` Kalle Valo
2018-11-05 8:24 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21e6a75b-7728-761d-d899-395864226fb5@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=davem@davemloft.net \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=plaes@plaes.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®