Re: [RFC v1 2/2] platform/x86/amd: Add AMD DPTCi driver

[Sasha Levin <sashal@kernel.org>]

On Tue, Mar 03, 2026 at 02:54:59PM -0600, Mario Limonciello (AMD) (kernel.org) wrote:
>+ Sasha
>
>On 3/3/2026 2:40 PM, Antheas Kapenekakis wrote:
>>On Tue, 3 Mar 2026 at 21:10, Mario Limonciello (AMD) (kernel.org)
>><superm1@kernel.org> wrote:
>>>
>>>I'll preface this by saying - I don't have a problem with using an AI to
>>>help write a driver, but please disclose that it was done and that in
>>>this case even you haven't closely audited the results.
>>>
>>>I personally would never submit something generated by an LLM that I
>>>didn't audit and add a S-o-b tag to it (asserting I am willing to stand
>>>by the code).
>>>
>>>I'm glad that I found out it was AI written before I started to review
>>>the code, I would have had a lot more candid comments for you.
>>>
>>>There is a lot of weird stuff in this driver that I'm not going to
>>>comment on and nitpick, but I'll leave a few broad strokes things.
>>
>>Of course, to that end, feel free to skip a full review until I get to
>>properly rewriting it.
>>
>>What is the current stance on Co-bys for that? I'm trying to follow
>>the discussion but I missed the news. I can lint it properly next
>>time.
>>
>> From my perspective, pouring a month into a driver like this without
>>having a firm commitment that it will go somewhere is a bit hard to
>>stomach.
>
>Sure.
>
>I don't need a dedicated tag telling me what tool you wrote it with.  
>I don't care if it was Opus, Gemini or Qwen3.5.  They all can make 
>mistakes that need to be audited.
>
>The most important part to me (or any reviewer) is a signal that I 
>shouldn't invest more effort reviewing this than you did writing it 
>and reviewing it.
>
>My feeling on this kind of RFC this is the most appropriate tag:
>
>Not-signed-off-by: Foo Bar <foo@bar.com>

We have docs for this now :) Both in the README file as well as
Documentation/process/coding-assistants.rst .

In particular, you should be upfront about using AI to generate code, using the
Assisted-by: tag, and definitely giving it a very careful review making sure
you completely understand what the code does.

As the README says:

   The human submitter is responsible for:

   * Reviewing all AI-generated code
   * Ensuring compliance with licensing requirements
   * Adding their own Signed-off-by tag to certify the DCO
   * Taking full responsibility for the contribution

-- 
Thanks,
Sasha