* [PATCH v2] iio: adc: ti-ads1119: Reinit completion before wait_for_completion_timeout()
@ 2026-03-03 13:47 Felix Gu
2026-03-04 12:27 ` Francesco Dolcini
0 siblings, 1 reply; 2+ messages in thread
From: Felix Gu @ 2026-03-03 13:47 UTC (permalink / raw)
To: Francesco Dolcini, João Paulo Gonçalves,
Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko
Cc: Jonathan Cameron, João Paulo Gonçalves,
Francesco Dolcini, linux-iio, linux-kernel, Felix Gu
The completion is not reinit before wait_for_completion_timeout(),
so wait_for_completion_timeout() will return immediately after
the first successful completion.
Fixes: a9306887eba4 ("iio: adc: ti-ads1119: Add driver")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
Changes in v2:
- Fix Jonathan's comment.
- Link to v1: https://lore.kernel.org/r/20260303-ti-ads1119-1-v1-1-e3fced089a44@gmail.com
---
drivers/iio/adc/ti-ads1119.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/iio/adc/ti-ads1119.c b/drivers/iio/adc/ti-ads1119.c
index c9cedc59cdcd..049cdb108dad 100644
--- a/drivers/iio/adc/ti-ads1119.c
+++ b/drivers/iio/adc/ti-ads1119.c
@@ -280,6 +280,9 @@ static int ads1119_single_conversion(struct ads1119_state *st,
if (ret)
goto pdown;
+ if (st->client->irq)
+ reinit_completion(&st->completion);
+
ret = i2c_smbus_write_byte(st->client, ADS1119_CMD_START_SYNC);
if (ret)
goto pdown;
---
base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31
change-id: 20260303-ti-ads1119-1-cc68e3c01783
Best regards,
--
Felix Gu <ustc.gu@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] iio: adc: ti-ads1119: Reinit completion before wait_for_completion_timeout()
2026-03-03 13:47 [PATCH v2] iio: adc: ti-ads1119: Reinit completion before wait_for_completion_timeout() Felix Gu
@ 2026-03-04 12:27 ` Francesco Dolcini
0 siblings, 0 replies; 2+ messages in thread
From: Francesco Dolcini @ 2026-03-04 12:27 UTC (permalink / raw)
To: Felix Gu
Cc: Francesco Dolcini, João Paulo Gonçalves,
Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Jonathan Cameron,
João Paulo Gonçalves, Francesco Dolcini, linux-iio,
linux-kernel
Hello Felix,
thanks for the patch
On Tue, Mar 03, 2026 at 09:47:33PM +0800, Felix Gu wrote:
> The completion is not reinit before wait_for_completion_timeout(),
> so wait_for_completion_timeout() will return immediately after
> the first successful completion.
>
> Fixes: a9306887eba4 ("iio: adc: ti-ads1119: Add driver")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-04 12:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-03 13:47 [PATCH v2] iio: adc: ti-ads1119: Reinit completion before wait_for_completion_timeout() Felix Gu
2026-03-04 12:27 ` Francesco Dolcini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®