From: Herbert Xu <herbert@gondor.apana.org.au>
To: T Pratham <t-pratham@ti.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Manorit Chawdhry <m-chawdhry@ti.com>,
Kamlesh Gurudasani <kamlesh@ti.com>,
Shiva Tripathi <s-tripathi1@ti.com>,
Kavitha Malarvizhi <k-malarvizhi@ti.com>,
Vishal Mahaveer <vishalm@ti.com>,
Praneeth Bajjuri <praneeth@ti.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 2/3] crypto: ti - Add support for AES-GCM in DTHEv2 driver
Date: Sat, 7 Mar 2026 14:23:58 +0900 [thread overview]
Message-ID: <aau2bg4gdM0VPcEo@gondor.apana.org.au> (raw)
In-Reply-To: <20260226125441.3559664-3-t-pratham@ti.com>
On Thu, Feb 26, 2026 at 06:24:40PM +0530, T Pratham wrote:
>
> + src = dthe_aead_prep_src(req->src, req->assoclen, cryptlen,
> + src_assoc_padbuf, src_crypt_padbuf);
> + if (IS_ERR(src)) {
> + ret = PTR_ERR(src);
> + goto aead_prep_src_err;
> + }
> +
> + if (req->assoclen % AES_BLOCK_SIZE)
> + assoclen += AES_BLOCK_SIZE - (req->assoclen % AES_BLOCK_SIZE);
> + if (cryptlen % AES_BLOCK_SIZE)
> + cryptlen += AES_BLOCK_SIZE - (cryptlen % AES_BLOCK_SIZE);
> +
> + src_nents = sg_nents_for_len(src, assoclen + cryptlen);
> +
> + if (cryptlen != 0) {
> + dst = dthe_aead_prep_dst(req->dst, req->assoclen, unpadded_cryptlen,
> + dst_crypt_padbuf);
> + if (IS_ERR(dst)) {
> + ret = PTR_ERR(dst);
> + goto aead_prep_dst_err;
> + }
> +
> + dst_nents = sg_nents_for_len(dst, cryptlen);
> + }
> + /* Prep finished */
How does this handle the case where req->src == req->dst?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2026-03-07 5:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 12:54 [PATCH v10 0/3] Add support for more AES modes in TI DTHEv2 T Pratham
2026-02-26 12:54 ` [PATCH v10 1/3] crypto: ti - Add support for AES-CTR in DTHEv2 driver T Pratham
2026-03-07 5:35 ` Herbert Xu
2026-02-26 12:54 ` [PATCH v10 2/3] crypto: ti - Add support for AES-GCM " T Pratham
2026-03-07 5:23 ` Herbert Xu [this message]
2026-03-10 17:05 ` T Pratham
2026-03-11 4:16 ` Herbert Xu
2026-03-11 5:32 ` T Pratham
2026-02-26 12:54 ` [PATCH v10 3/3] crypto: ti - Add support for AES-CCM " T Pratham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aau2bg4gdM0VPcEo@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=k-malarvizhi@ti.com \
--cc=kamlesh@ti.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-chawdhry@ti.com \
--cc=praneeth@ti.com \
--cc=s-tripathi1@ti.com \
--cc=t-pratham@ti.com \
--cc=vishalm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®