From: Herbert Xu <herbert@gondor.apana.org.au>
To: T Pratham <t-pratham@ti.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Manorit Chawdhry <m-chawdhry@ti.com>,
Kamlesh Gurudasani <kamlesh@ti.com>,
Shiva Tripathi <s-tripathi1@ti.com>,
Kavitha Malarvizhi <k-malarvizhi@ti.com>,
Vishal Mahaveer <vishalm@ti.com>,
Praneeth Bajjuri <praneeth@ti.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 2/3] crypto: ti - Add support for AES-GCM in DTHEv2 driver
Date: Wed, 11 Mar 2026 13:16:57 +0900 [thread overview]
Message-ID: <abDsufbNKkUa1msb@gondor.apana.org.au> (raw)
In-Reply-To: <26303ab7-cd14-4560-8872-021229faa137@ti.com>
On Tue, Mar 10, 2026 at 10:35:15PM +0530, T Pratham wrote:
>
> What potential issue do you see? Both `dthe_aead_prep_src` and
> `dthe_prep_aead_dst` functions use `sg_split`, which anyway allocates a
> new scatterlist. Even if req->src == req->dst, the src and dst from here
> on will be different.
The copied SG list will still point to the original memroy, right?
In that case you will end up DMA mapping the same region twice, once
as input and once as output. I don't think that's guaranteed to
work, as you're supposed to map it once as BIDIRECTIONAL.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2026-03-11 4:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 12:54 [PATCH v10 0/3] Add support for more AES modes in TI DTHEv2 T Pratham
2026-02-26 12:54 ` [PATCH v10 1/3] crypto: ti - Add support for AES-CTR in DTHEv2 driver T Pratham
2026-03-07 5:35 ` Herbert Xu
2026-02-26 12:54 ` [PATCH v10 2/3] crypto: ti - Add support for AES-GCM " T Pratham
2026-03-07 5:23 ` Herbert Xu
2026-03-10 17:05 ` T Pratham
2026-03-11 4:16 ` Herbert Xu [this message]
2026-03-11 5:32 ` T Pratham
2026-02-26 12:54 ` [PATCH v10 3/3] crypto: ti - Add support for AES-CCM " T Pratham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abDsufbNKkUa1msb@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=k-malarvizhi@ti.com \
--cc=kamlesh@ti.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-chawdhry@ti.com \
--cc=praneeth@ti.com \
--cc=s-tripathi1@ti.com \
--cc=t-pratham@ti.com \
--cc=vishalm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®