* [PATCH v2] dt-bindings: gnss: add u-blox,neo-9m compatible
@ 2025-05-22 16:18 Alejandro Enrique via B4 Relay
2025-05-22 17:36 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Alejandro Enrique via B4 Relay @ 2025-05-22 16:18 UTC (permalink / raw)
To: Johan Hovold, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-kernel, devicetree, Alejandro Enrique
From: Alejandro Enrique <alejandroe1@geotab.com>
Add compatible for u-blox NEO-9M GPS module.
Signed-off-by: Alejandro Enrique <alejandroe1@geotab.com>
---
This series just add the compatible string for u-blox NEO-9M module,
using neo-m8 as fallback. I have tested the driver with such a module
and it is working fine.
---
Changes in v2:
- Modify the binding to allow falling back to neo-m8
- Remove compatible string from u-blox driver
- Link to v1: https://lore.kernel.org/r/20250514-ubx-m9-v1-0-193973a4f3ca@geotab.com
---
Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 25 +++++++++++++++++++++----
1 file changed, 21 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
index 7d4b6d49e5eea2201ac05ba6d54b1c1721172f26..215f8931ca08c1b0954fc2f70eabe3ec8d89edea 100644
--- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
+++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
@@ -18,10 +18,16 @@ description: >
properties:
compatible:
- enum:
- - u-blox,neo-6m
- - u-blox,neo-8
- - u-blox,neo-m8
+ oneOf:
+ - items:
+ - enum:
+ - u-blox,neo-6m
+ - u-blox,neo-8
+ - u-blox,neo-m8
+
+ - items:
+ - const: u-blox,neo-m9
+ - const: u-blox,neo-m8
reg:
description: >
@@ -63,3 +69,14 @@ examples:
reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
};
};
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ serial {
+ gnss {
+ compatible = "u-blox,neo-m9", "u-blox,neo-m8";
+ v-bckp-supply = <&gnss_v_bckp_reg>;
+ vcc-supply = <&gnss_vcc_reg>;
+ reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
+ };
+ };
---
base-commit: 9c32cda43eb78f78c73aee4aa344b777714e259b
change-id: 20250514-ubx-m9-70df0fd8c48b
Best regards,
--
Alejandro Enrique <alejandroe1@geotab.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] dt-bindings: gnss: add u-blox,neo-9m compatible
2025-05-22 16:18 [PATCH v2] dt-bindings: gnss: add u-blox,neo-9m compatible Alejandro Enrique via B4 Relay
@ 2025-05-22 17:36 ` Krzysztof Kozlowski
2025-05-23 11:11 ` Alejandro Enrique
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-22 17:36 UTC (permalink / raw)
To: alejandroe1, Johan Hovold, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-kernel, devicetree
On 22/05/2025 18:18, Alejandro Enrique via B4 Relay wrote:
> From: Alejandro Enrique <alejandroe1@geotab.com>
>
> Add compatible for u-blox NEO-9M GPS module.
>
> Signed-off-by: Alejandro Enrique <alejandroe1@geotab.com>
> ---
> This series just add the compatible string for u-blox NEO-9M module,
> using neo-m8 as fallback. I have tested the driver with such a module
> and it is working fine.
> ---
> Changes in v2:
> - Modify the binding to allow falling back to neo-m8
> - Remove compatible string from u-blox driver
> - Link to v1: https://lore.kernel.org/r/20250514-ubx-m9-v1-0-193973a4f3ca@geotab.com
> ---
> Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 25 +++++++++++++++++++++----
> 1 file changed, 21 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> index 7d4b6d49e5eea2201ac05ba6d54b1c1721172f26..215f8931ca08c1b0954fc2f70eabe3ec8d89edea 100644
> --- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> +++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> @@ -18,10 +18,16 @@ description: >
>
> properties:
> compatible:
> - enum:
> - - u-blox,neo-6m
> - - u-blox,neo-8
> - - u-blox,neo-m8
> + oneOf:
> + - items:
Drop items here, just enum directly.
> + - enum:
> + - u-blox,neo-6m
> + - u-blox,neo-8
> + - u-blox,neo-m8
> +
Drop blank line.
> + - items:
> + - const: u-blox,neo-m9
> + - const: u-blox,neo-m8
>
> reg:
> description: >
> @@ -63,3 +69,14 @@ examples:
> reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
> };
> };
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + serial {
> + gnss {
> + compatible = "u-blox,neo-m9", "u-blox,neo-m8";
No need for new example, it's the same as previous.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] dt-bindings: gnss: add u-blox,neo-9m compatible
2025-05-22 17:36 ` Krzysztof Kozlowski
@ 2025-05-23 11:11 ` Alejandro Enrique
0 siblings, 0 replies; 3+ messages in thread
From: Alejandro Enrique @ 2025-05-23 11:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Johan Hovold, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-kernel, devicetree
On Thu, May 22, 2025 at 7:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 22/05/2025 18:18, Alejandro Enrique via B4 Relay wrote:
> > From: Alejandro Enrique <alejandroe1@geotab.com>
> >
> > Add compatible for u-blox NEO-9M GPS module.
> >
> > Signed-off-by: Alejandro Enrique <alejandroe1@geotab.com>
> > ---
> > This series just add the compatible string for u-blox NEO-9M module,
> > using neo-m8 as fallback. I have tested the driver with such a module
> > and it is working fine.
> > ---
> > Changes in v2:
> > - Modify the binding to allow falling back to neo-m8
> > - Remove compatible string from u-blox driver
> > - Link to v1: https://lore.kernel.org/r/20250514-ubx-m9-v1-0-193973a4f3ca@geotab.com
> > ---
> > Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 25 +++++++++++++++++++++----
> > 1 file changed, 21 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> > index 7d4b6d49e5eea2201ac05ba6d54b1c1721172f26..215f8931ca08c1b0954fc2f70eabe3ec8d89edea 100644
> > --- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> > +++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> > @@ -18,10 +18,16 @@ description: >
> >
> > properties:
> > compatible:
> > - enum:
> > - - u-blox,neo-6m
> > - - u-blox,neo-8
> > - - u-blox,neo-m8
> > + oneOf:
> > + - items:
>
> Drop items here, just enum directly.
>
> > + - enum:
> > + - u-blox,neo-6m
> > + - u-blox,neo-8
> > + - u-blox,neo-m8
> > +
>
> Drop blank line.
>
> > + - items:
> > + - const: u-blox,neo-m9
> > + - const: u-blox,neo-m8
> >
> > reg:
> > description: >
> > @@ -63,3 +69,14 @@ examples:
> > reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
> > };
> > };
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > +
> > + serial {
> > + gnss {
> > + compatible = "u-blox,neo-m9", "u-blox,neo-m8";
>
> No need for new example, it's the same as previous.
>
>
> Best regards,
> Krzysztof
Thanks. I will apply the changes.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-23 11:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-22 16:18 [PATCH v2] dt-bindings: gnss: add u-blox,neo-9m compatible Alejandro Enrique via B4 Relay
2025-05-22 17:36 ` Krzysztof Kozlowski
2025-05-23 11:11 ` Alejandro Enrique
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®