From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Wang Jun <1742789905@qq.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Andy Shevchenko <andy@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
gszhai@bjtu.edu.cn, 25125332@bjtu.edu.cn, 25125283@bjtu.edu.cn,
23120469@bjtu.edu.cn
Subject: Re: [PATCH V2] auxdisplay: lcd2s: add error handling for i2c transfers
Date: Thu, 12 Mar 2026 16:24:37 +0200 [thread overview]
Message-ID: <abLMpal_V_xRhYhp@ashevche-desk.local> (raw)
In-Reply-To: <tencent_D7431077E4279D21A806EB2FB8AE0F018D07@qq.com>
On Thu, Mar 12, 2026 at 09:25:02PM +0800, Wang Jun wrote:
> The lcd2s_print() and lcd2s_gotoxy() functions currently ignore the
> return value of lcd2s_i2c_master_send(), which can fail. This can lead
> to silent data loss or incorrect cursor positioning.
>
> Add proper error checking: if the number of bytes sent does not match
> the expected length, return -EIO; otherwise propagate any error code
> from the I2C transfer.
Why?
Where is the changelog if it's a v2?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-12 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 2:02 [PATCH] " Wang Jun
2026-03-10 10:17 ` Andy Shevchenko
2026-03-12 13:25 ` [PATCH V2] " Wang Jun
2026-03-12 14:24 ` Andy Shevchenko [this message]
2026-03-12 14:51 ` [PATCH v3] " Wang Jun
2026-03-13 10:02 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abLMpal_V_xRhYhp@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=1742789905@qq.com \
--cc=23120469@bjtu.edu.cn \
--cc=25125283@bjtu.edu.cn \
--cc=25125332@bjtu.edu.cn \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=geert@linux-m68k.org \
--cc=gszhai@bjtu.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®