From: Jingyi Wang <quic_jingyw@quicinc.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"Richard Cochran" <richardcochran@gmail.com>,
<quic_tengfan@quicinc.com>, <quic_tingweiz@quicinc.com>,
<quic_aiquny@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
<linux-gpio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] pinctrl: qcom: add the tlmm driver for QCS8300 platforms
Date: Thu, 17 Oct 2024 10:24:54 +0800 [thread overview]
Message-ID: <abbea1df-4aaa-4012-95f9-ea1419a22414@quicinc.com> (raw)
In-Reply-To: <c7ahyrbo3bw6vgfwqaubricap52muhxyhsnb5cfhzvo3n67dsr@gp6vehlfwblo>
On 10/16/2024 5:25 PM, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Oct 09, 2024 at 03:13:34PM +0800, Jingyi Wang wrote:
>> +static struct platform_driver qcs8300_pinctrl_driver = {
>> + .driver = {
>> + .name = "qcs8300-tlmm",
>> + .of_match_table = qcs8300_pinctrl_of_match,
>> + },
>> + .probe = qcs8300_pinctrl_probe,
>> + .remove_new = msm_pinctrl_remove,
>> +};
>
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers. Please just drop "_new".
>
Will update that, thx!
> Best regards
> Uwe
Thanks,
Jingyi
prev parent reply other threads:[~2024-10-17 2:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 7:13 [PATCH v2 0/2] pinctrl: qcom: Introduce Pinctrl for QCS8300 Jingyi Wang
2024-10-09 7:13 ` [PATCH v2 1/2] dt-bindings: pinctrl: describe qcs8300-tlmm Jingyi Wang
2024-10-09 7:13 ` [PATCH v2 2/2] pinctrl: qcom: add the tlmm driver for QCS8300 platforms Jingyi Wang
2024-10-10 12:56 ` Dmitry Baryshkov
2024-10-11 5:46 ` Jingyi Wang
2024-10-16 9:25 ` Uwe Kleine-König
2024-10-17 2:24 ` Jingyi Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abbea1df-4aaa-4012-95f9-ea1419a22414@quicinc.com \
--to=quic_jingyw@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quic_aiquny@quicinc.com \
--cc=quic_tengfan@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®